Commit Graph

3243 Commits

Author SHA1 Message Date
7aa36b77ea Guarantee router session is present for call to clientReply; properly free callbacks; attempt to set all necessary values for dbusers; do more to ensure buffers freed. 2015-09-21 14:25:12 +01:00
11c8ef5b92 Cleaned up code based on the review of the code. 2015-09-21 14:02:01 +03:00
988a8d7008 Fixed error messages not being printed and cleaned up the function. 2015-09-21 14:02:01 +03:00
561891aac5 Fix for double free, possible fix for bug601.
In the end of execute_sescmd_in_backend the buffer was consumed
in case the protocol function failed. Or actually if it returned
something else but 1.

In the case of mysql_backend, the buffer is always freed when
authorizing and either consumed or placed on the dcb writequeue
when the data is written.

That is, it is never ok to consume the buffer in this function.
The end-result is likely to be an abort.
2015-09-21 13:45:15 +03:00
88716c35fb Various changes to block loopholes in different cases and tidy up. 2015-09-21 09:23:22 +01:00
de8e54da8b Fix for compile error
Fix for compile error
2015-09-21 09:00:39 +02:00
2c12ba3d16 Various fixes
Various fixes for initialisation and packet size allocation
2015-09-21 09:00:20 +02:00
f97df72a3e Fix for compile error
Fix for compile error
2015-09-21 08:52:39 +02:00
2ce6012506 Various fixes
Various fixes for initialisation and packet size allocation
2015-09-21 08:44:33 +02:00
511e0fe119 Merge Fix from develop
Merge Fix from develop
2015-09-18 16:10:41 +02:00
8d5ca11374 Fixed: spinlock_release is before free
Fixed: spinlock_release is before free
2015-09-18 16:05:22 +02:00
89748d9b21 Binlog identity log message update
Binlog identity log message update
2015-09-18 11:18:32 +02:00
840afc0815 Develop merge
Develop merge
2015-09-18 11:15:48 +02:00
2a2582067a Added fix blr_slave_register reply
Added fix blr_slave_register reply
2015-09-18 11:06:03 +02:00
67069d1685 Fixed Typo
Fixed Typo
2015-09-18 11:01:54 +02:00
74d69eb64d Added missing slave state BLRS_REGISTERED
Added missing slave state BLRS_REGISTERED
2015-09-18 10:50:12 +02:00
e507933c48 Need to mark the DCB dcb_errhandle_called indicator if the router error handler is not called. 2015-09-18 09:19:32 +01:00
81e186fd92 server-id reported as server_id in binlog_identity log
server-id reported as server_id in binlog_identity log
2015-09-18 10:09:11 +02:00
f3560512ff Suppress call to router error handling where there is no router session. 2015-09-18 09:04:32 +01:00
c69658889c Handle client input case where no router session exists by sending error message to client. 2015-09-18 08:59:06 +01:00
c26dfbc779 Added blr_slave_send_ok in blr_slave_register
Added blr_slave_send_ok in blr_slave_register
2015-09-18 09:37:07 +02:00
cbfc6ea6b0 Fix OK packet for blr_slave_register() reply
Fix OK packet for blr_slave_register() reply
2015-09-18 09:23:02 +02:00
31c6666278 Ensure DCB for closing session does not become persistent; remove bref_was_not_in_use. 2015-09-17 14:38:56 +01:00
dc3b0b067b Revert the dcb_close changes in handleError. 2015-09-17 13:35:18 +01:00
1ad8e27c91 Try a different arrangement of DCB closures in handleError of read-write split. 2015-09-17 13:27:25 +01:00
357c4bcae5 Add to or take from persistent pool only if server is running; add conditions to DCB close in read-write handleError to check backend reference was in use. 2015-09-17 12:53:59 +01:00
583c9b62fe Close DCB in handleError only if it can be found in a backend reference. 2015-09-17 11:58:19 +01:00
0cba9b797f Changes to deal with failed session creation by keeping the new session in existence until all related DCBs have closed; minor changes in response to reviews. 2015-09-17 08:15:32 +01:00
11c4a1a491 Merge branch 'develop' into 1.2.1-binlog_router_trx 2015-09-16 19:09:08 +02:00
9829a8c2c2 Added: validating binlog file message
Added: validating binlog file message
2015-09-16 19:04:48 +02:00
633131fffd Fix for information_schema.STATUS in Uptime
Fix for information_schema.STATUS in Uptime
2015-09-16 18:15:12 +02:00
3822cae9c2 blr_log_identity() moved to the right location
blr_log_identity() moved to the right location
2015-09-16 17:28:32 +02:00
e4677fbd44 Log message fix
Log message fix
2015-09-16 17:16:20 +02:00
faaf33918d Binlog Identity is logged with MESSAGE
Binlog Identity is logged with MESSAGE
2015-09-16 15:44:50 +02:00
6ad89cb986 Removed boolean value assignment to an integer variable. 2015-09-16 13:36:33 +03:00
6c75e09f29 Fixed multi-source replication not working. 2015-09-16 11:54:56 +03:00
30239f395a Fix bref when backend server fails, error message if fails. 2015-09-15 20:07:56 +01:00
fac4b3ff11 Fix for MariaDB 10
Fix for MariaDB 10
2015-09-15 19:10:23 +02:00
c12233db0d Small fixes
Small fixes
2015-09-15 16:50:15 +02:00
fdbe070e80 Change abort to error message when read connection router finds mismatch between router client session DCB and given backend DCB; improve order of actions when closing DCB in read-write router. 2015-09-15 15:22:44 +01:00
374056cecc Valgrind fixes
Valgrind fixes
2015-09-15 16:18:10 +02:00
4732cc639c Error handling for invalid SHOW [GLOBAL] STATUS command
Error handling for invalid SHOW [GLOBAL] STATUS command
2015-09-15 15:57:31 +02:00
6b05176684 Fixed errors reported by valgrind
Fixed errors reported by valgrind
2015-09-15 15:49:41 +02:00
abf5b6d02a Addition of status variable output formatting
Addition of status variable output formatting and router options check
and check for mandatory server_id parameter
Logging of binlog router identy seen by master and slaves
2015-09-15 15:13:05 +02:00
6817db3ae1 Added checks for empty values
Added checks for empty values
2015-09-15 09:48:04 +02:00
0cf4b2cf68 Fix to overcome failure on certain packets. 2015-09-15 08:37:41 +01:00
3f4acf4bc5 Added support for SHOW [GLOBAL] STATUS LIKE 'Uptime'
Added support for SHOW [GLOBAL] STATUS LIKE 'Uptime'
2015-09-15 09:17:52 +02:00
9cd9a6183b Merge branch 'develop' into 1.2.1-binlog_router_trx 2015-09-14 21:13:14 +02:00
2829a8ce05 Added missing check for empty result set in binlogrouter. 2015-09-14 21:20:22 +03:00
c2c27d7cca Merge from develop
Merge from develop
2015-09-14 09:49:33 +02:00