VilhoRaatikka
b84797bfa6
Fix to Coverity issue 72749, replaced sprintf with snprintf
2014-11-05 15:32:57 +02:00
VilhoRaatikka
d611622b23
Fix to Coverity issue 72738, passed NULL-pointer to a function which referenced it.
2014-11-05 15:21:17 +02:00
VilhoRaatikka
43b4224d2d
Merge branch 'develop' of https://github.com/mariadb-corporation/MaxScale into develop
2014-11-05 14:43:22 +02:00
VilhoRaatikka
8b91a5f078
Fix to bug #610 , http://bugs.mariadb.com/show_bug.cgi?id=610
...
Fixes to Coverity issues 72728, 72755, 72745
2014-11-05 14:41:04 +02:00
Markus Makela
699d07a613
Merge branch 'develop' of https://github.com/mariadb-corporation/MaxScale into develop
2014-11-05 14:22:46 +02:00
Markus Makela
36c6a61330
Fixes to coverity bugs:
...
72670: query_classifier/query_classifier.cc
72682: server/modules/filter/qlafilter.c
72679: server/modules/filter/tee.c
72716: server/modules/protocol/maxscaled.c
72694: server/modules/protocol/telnetd.c
71743: server/modules/routing/readwritesplit/readwritesplit.c
2014-11-05 14:18:38 +02:00
VilhoRaatikka
5886ac3d31
Merge branch 'develop' of https://github.com/mariadb-corporation/MaxScale into develop
2014-11-05 12:16:05 +02:00
VilhoRaatikka
42fc241cb7
Added comment to server selection routine
2014-11-05 12:15:48 +02:00
Markus Makela
17f87e29af
Fixes to some Coverity issues.
2014-11-05 11:57:42 +02:00
counterpoint
3395caf208
Fix two other incorrect pointers, changing bitmask to bitmask->bits.
2014-11-05 09:29:21 +00:00
VilhoRaatikka
3278be565a
Fix to bug #609 , http://bugs.mariadb.com/show_bug.cgi?id=609
...
If target can't be resolved, master is chosen. Bug cause master be chosen in most of the cases.
2014-11-05 11:18:25 +02:00
Markus Makela
a493a841d9
Fix to harness_common.c Coverity errors.
2014-11-04 18:21:31 +02:00
counterpoint
c63f2af160
Fix bug in bitmask extension.
2014-11-04 11:36:06 +00:00
Markus Makela
1b9da8662d
Fixed Coverity errors that were in harness_common.c
2014-11-04 11:37:26 +02:00
Markus Makela
99707853be
Changed the requirement of -Werror=format-security to GCC version 4.2 or greater instead of only versions greater than 4.2.
2014-11-04 10:55:30 +02:00
Markus Makela
1fc66c0df7
Updated the GCC required version to 4.2 for '-Werror=format-security' to be used.
2014-11-04 10:49:28 +02:00
Markus Makela
e786d4af78
fix to bug 606, added a check that the compiler version is greater than 4.1 if GNU compilers are used when using -Werror=format-security.
2014-11-04 10:40:24 +02:00
VilhoRaatikka
85455a2a7e
Merge branch 'develop' of https://github.com/mariadb-corporation/MaxScale into develop
2014-11-03 22:08:41 +02:00
VilhoRaatikka
6ed8836b15
dcb.c:dcb_close prevent redundant execution of dcb_close for one DCB
2014-11-03 22:07:54 +02:00
Markus Makela
e7feba6964
Fixed canonical query tests
2014-11-03 13:00:46 +02:00
VilhoRaatikka
ca816743e8
Returned #include <my_config.h> and updated server name.
2014-11-03 11:33:41 +02:00
VilhoRaatikka
b15ac9c019
Revert to 54d389e329a860add1f609508c676761521a8ad0 due to erroneous fix.
2014-11-03 08:57:02 +02:00
VilhoRaatikka
fb02e44e7e
Fix to #605 , http://bugs.mariadb.com/show_bug.cgi?id=605
...
Main assumed multi-byte characters in memory allocation but not outside of it so I removed that code and made it consistently assume single-byte characters.
Terminating character was added always to the last byte of string buffer regardless of the length of the string. Removed it and replaced malloc with calloc.
Moved variable introductions from the middle of the function to the beginning of it.
2014-11-02 22:33:12 +02:00
VilhoRaatikka
aaa727bcc2
Fix to bug #605 , http://bugs.mariadb.com/show_bug.cgi?id=605
...
String buffer allocation didn't allocate space for terminating char. It also assumed that character size may vary but the rest of the code didn't support multi-byte characters so I changed it consistently assume single-byte characters.
2014-11-02 22:11:28 +02:00
VilhoRaatikka
54d389e329
Fix to Coverity issue 72733
2014-11-01 21:16:03 +02:00
VilhoRaatikka
10f8d0535a
Fixes to Coverity tasks 72734, 72717, 72700
2014-11-01 20:33:17 +02:00
VilhoRaatikka
9ccbab1899
poll.c:dcb_close Don't call poll_remove_dcb anymore if DCB has already been removed from poll set.
...
mysql_backend.c, mysql_client.c free error message GWBUF after calling handleError
readconnroute.c:handleError send error message to client before returning.
readwritesplit.c:handleError don't free error message buffer anymore since the caller of handleError frees it.
2014-11-01 20:00:59 +02:00
VilhoRaatikka
b6fe4e620a
Fixed another leaking socket. Coverity 72706
2014-11-01 15:28:41 +02:00
VilhoRaatikka
f1c4c1dfb2
Fixed one more socket leak
2014-11-01 00:01:38 +02:00
VilhoRaatikka
5a2d492fe8
Fixed use of uninitialized memory.
2014-10-31 23:47:33 +02:00
VilhoRaatikka
8aff04b0e9
Fixed Coverity case 72706
2014-10-31 23:35:29 +02:00
VilhoRaatikka
deffd4a69f
Fix to Coverity cases 73417, 73420, 72759, 72639
2014-10-31 23:11:19 +02:00
VilhoRaatikka
3f375e680a
Fix to #590 , http://bugs.mariadb.com/show_bug.cgi?id=590
...
gw_change_user returned error code in cases where authentication failed. That is not right behavior in that context. gw_change_user succeeds to route query and should return succees to router's routeQuery. Possible error is handled by creating error message and by feeding it to client DCB's event queue.
2014-10-31 20:09:43 +02:00
MassimilianoPinto
e812d765ef
Added Master Failback in show monitors
...
Added Master Failback in show monitors
2014-10-31 17:17:02 +01:00
MassimilianoPinto
3739e3ce56
Merge branch 'develop' into MAX-316
2014-10-31 15:45:05 +01:00
VilhoRaatikka
a342b453ac
Fixed Coverity tasks : 72722, 72706
2014-10-31 15:55:13 +02:00
VilhoRaatikka
7615e9c0ac
Merge branch 'develop' of https://github.com/mariadb-corporation/MaxScale into develop
2014-10-31 15:28:58 +02:00
VilhoRaatikka
00fded016b
Fixes to Coverity tasks : 73267, 72686, 72672
...
Cleaned up warnings, and added checks to malloc return values and error log writes in case of failures.
2014-10-31 15:25:59 +02:00
Markus Makela
002bfb5c35
Added 'make documentation' target to CMake that generates documentation with Doxygen.
2014-10-31 12:44:20 +02:00
MassimilianoPinto
09b3351427
Added mysqld_error.h in dbusers
...
Added mysqld_error.h in dbusers
2014-10-31 11:22:15 +01:00
VilhoRaatikka
848c7aa0b8
Fixes to Coverity cases 72678 (retry), 72693
2014-10-31 11:38:57 +02:00
VilhoRaatikka
e739f3501b
Merge branch 'develop' of https://github.com/mariadb-corporation/MaxScale into develop
2014-10-30 21:20:32 +02:00
VilhoRaatikka
5b80cf3032
If opening any of the log files fail, MaxScale doesn't start before the cause has been removed. Added informative error message which is to be printed to standard error output.
2014-10-30 21:19:26 +02:00
MassimilianoPinto
6f22975e6c
Added 'disable_master_failback' monitor option
...
Added 'disable_master_failback' option in Galera monitor
2014-10-30 19:03:07 +01:00
MassimilianoPinto
9967a45379
Disable Master failback in Galera Monitor
...
Disable Master failback in Galera Monitor
2014-10-30 18:41:30 +01:00
MassimilianoPinto
41f016df18
Coverity 72644
...
Coverity 72644
2014-10-30 17:26:55 +01:00
MassimilianoPinto
fabf62c065
Coverity 72739
...
Coverity 72739
2014-10-30 17:23:24 +01:00
VilhoRaatikka
bb0fc97f00
Merge branch 'develop' of https://github.com/mariadb-corporation/MaxScale into develop
2014-10-30 18:20:54 +02:00
VilhoRaatikka
7048270062
Coverity : 72678, 72687, 72689
...
Fixed memory leaks and use of freed memory
2014-10-30 18:19:41 +02:00
MassimilianoPinto
237975ebcd
Coverity 72692
...
Coverity 72692
2014-10-30 17:16:59 +01:00