Commit Graph

13730 Commits

Author SHA1 Message Date
d5e8315290 Assert that buffers are non-null in mysql.h
The functions assume that the buffer is never null and thus should be
asserted.
2019-05-31 14:01:15 +03:00
a4ee390fe5 Never construct mxs::Buffer from nullptr
A mxs::Buffer should never be constructed from a null pointer and if done,
it is very likely due to an error.
2019-05-31 14:01:15 +03:00
9df6c9aeca Fix weightby documentation
The parameter names were different.
2019-05-31 14:01:15 +03:00
47ae75c6a5 Make MXS_COM_UNDEFINED a part of the enum
This way it is a valid enum value and it prevents UBSAN from complaining
about it.
2019-05-31 14:01:14 +03:00
4e6ca33053 Add UBSAN flag to builds
The -DWITH_UBSAN flag enables the undefined behavior detection provided by
GCC.
2019-05-31 14:01:14 +03:00
ee7e63a611 MXS-2464: Assert that responses are expected
A query should not be queued if no responses are expected. The code that
executes queued queries should be dead code and this assertion would catch
it.
2019-05-31 14:01:14 +03:00
1012b95544 Merge branch '2.2' into 2.3 2019-05-31 12:40:15 +03:00
de3c5721e9 MXS-2513 Deprecate firewall and masking filters 2019-05-31 11:53:36 +03:00
2b3a9b2b57 Initialize MXS_SESSION::autocommit 2019-05-29 18:46:33 +03:00
ed63493875 Return valid values for undefined mdbci variables
If a variable is not defined in the network configuration, a valid value
is returned.
2019-05-29 18:46:33 +03:00
84986dbf92 MXS-2520: Add test case
The test reproduces the problem and verifies that the fix works.
2019-05-29 18:46:33 +03:00
81254953d1 MXS-2520: Allow master reconnection on reads
If only the master is available and a reconnection must take place, it
must be allowed to happen in all cases.
2019-05-29 18:46:33 +03:00
3b60bf00e1 Merge branch '2.3' into develop 2019-05-29 18:41:50 +03:00
442d8bed9a MXS-2479 Add username and host to PAM authenticator log messages 2019-05-29 17:32:27 +03:00
114e095e1b MXS-2525: Fix non-plugin authentication
Older clients assume the plugin used for authentication is
mysql_native_password. If the client doesn't request plugin
authentication, don't treat it as an error.
2019-05-29 12:41:53 +03:00
32769ddfb0 Fix maxavro build failure 2019-05-29 10:57:38 +03:00
2ddc20cf9e Merge branch '2.3' into develop 2019-05-28 15:19:10 +03:00
dcdcc0e44f Fix avrorouter build failure
Signed to unsigned comparison.
2019-05-28 15:18:34 +03:00
65c795164c Merge branch '2.3' into develop 2019-05-28 14:40:45 +03:00
006b87cebe MXS-2307: Extend alter test cases
The tests now check that multiple parameters work as expected. Also fixed
a few defects found while writing the tests, namely the fact that null or
empty values weren't detected.
2019-05-28 14:34:51 +03:00
3a9bfa380e MXS-2307: Allow multi-parameter updates
Multiple parameters can now be updated with a single call in MaxCtrl. This
makes alterations more convenient and prevents intermediate states when
multiple parameters are changed at the same time. The changes are
backwards compatible so it should not affect existing programs.
2019-05-28 14:34:51 +03:00
954c1157dc MXS-2483: Add note to set_context documentation
As the function is required by the binlogrouter, we cannot outright remove
it without refactoring how the servers are handled in it.
2019-05-28 14:34:51 +03:00
0462ac3d16 MXS-2483: Update documentation and release notes
Updated documentation on how servers with TLS are created.
2019-05-28 14:34:51 +03:00
21cdc4822b MXS-2483: Remove runtime enabling of TLS
TLS can no longer be enabled at runtime via maxadmin.
2019-05-28 14:34:50 +03:00
1d87a1c3bc MXS-2483: Document REST API corrections
The protocol parameter must always be explicitly defined.
2019-05-28 14:34:50 +03:00
9443e99a17 MXS-2483: Separate JSON server creation from legacy code
The servers created via the REST API now use code separate from the
maxadmin interface. This removes the cumbersome requirement of having to
first create the server and then configure it. With this change, it is
possible to completely remove the ability to set the server SSL after
creation.
2019-05-28 14:34:50 +03:00
cb77cffdf2 Separate MaxCtrl create options
The options for each command are now declared "inside" the command. This
makes the help output a lot clearer and only displays the options relevant
for the command in question.
2019-05-28 14:34:50 +03:00
0e88aac497 Fix extract_parameters_from_json
The function would only work for string parameters.
2019-05-28 14:34:50 +03:00
38b57497b9 MXS-2486: Move to_string into SSLProvider
The functionality is more a part of the provider than the context so it
should be defined in it. It also doesn't use any parts of the SSLContext
which makes it somewhat more clear that it doesn't belong there.
2019-05-28 14:34:50 +03:00
cab35b2dea MXS-2486: Fix listener serialization
The serialization should be done via the parameters. This also makes
SSLContext::serialize redundant.
2019-05-28 14:34:50 +03:00
bef8881cab Merge branch '2.2' into 2.3 2019-05-28 14:17:43 +03:00
edb669100d MXS-2511: Update connector-c
Updated to 3.0.10.
2019-05-28 14:00:28 +03:00
075ed00f58 MXS-2481 Fix rebase error 2019-05-28 12:43:21 +03:00
6e5f7fcfbf MXS-2481 Add timeout and comments
When node is taken down, we don't wait forever.
Added comments that make it easier to follow the test when it
is running.
2019-05-28 12:36:21 +03:00
dcc7d195a3 MXS-2481 Add/fix copyright blurb 2019-05-28 12:36:21 +03:00
71b648e965 MXS-2481 Test transaction replay at group change
Take down a node other than the one we are connected to, which
will cause a group change error, and test that MaxScale catches
that and replay the transaction.
2019-05-28 12:36:21 +03:00
e0b397455d MXS-2481 Check that server has changed 2019-05-28 12:36:21 +03:00
1c3ccfe254 MXS-2481 Factor out functionality
To be used by other test-case.
2019-05-28 12:36:21 +03:00
37e526eb8d MXS-2481 Rename test
No other changes.
2019-05-28 12:36:21 +03:00
2bcee1be8b MXS-2481 Test transaction replay when node goes down
Currently tests transaction replay when node goes down.
Group change test will be added and name of test will be
changed accordingly.
2019-05-28 12:36:21 +03:00
60d065473e MXS-2481 Handle sqlite3 oom error 2019-05-28 12:36:21 +03:00
feae0cda17 MXS-2481 Dont log confusing things
At first start there will be no persistent information. No point
in logging that we will not use that information.
2019-05-28 12:36:21 +03:00
1bd82555d9 MXS-2481 Add Clustrix group change test skeleton 2019-05-28 12:36:21 +03:00
7b803f621c MXS-2481 Change blurb 2019-05-28 12:36:21 +03:00
8204c5099b MXS-2481 Ensure directory exists before creating db 2019-05-28 12:36:21 +03:00
8a2c43d297 MXS-2481 Add configuration file template 2019-05-28 12:36:21 +03:00
18214b1aa2 MXS-2481 Add Clustrix module-command test
Softfailing should turn the state of a server to Drained.
2019-05-28 12:36:21 +03:00
c0a0bb86a0 MXS-2481 Add MaxRest functionality
- show_server
- call_command
2019-05-28 12:36:21 +03:00
c35d92eccc MXS-2481 Check that node-absense leads to Down
If MaxScale cannot ping the health-check port of a node, the
state of the node should become 'Down'.
2019-05-28 12:36:21 +03:00
a8487a945a MXS-2481 When Clustrix [un]block health port as well
In the case of Clustrix, it is not sufficient to block the MariaDB
port alone, but the health-check port must be blocked as well.
2019-05-28 12:36:21 +03:00