163a7b3b84
MXS-2917 Add missing destructors to sqlite rules (2.4)
2020-03-09 16:01:49 +02:00
55425b22ce
Merge branch '2.3' into 2.4
2020-03-09 15:45:37 +02:00
8dd9a4ca27
MXS-2917 Add missing destructors to sqlite rules
...
Lemon (the sqlite parser generator) destructors are needed for
all rules that return dynamically allocated structures. Otherwise
there may be leaks if a statement is not completely parsed.
2020-03-09 15:24:20 +02:00
f7d502d1e1
Use json_object_set_new
...
The non-set case should only be used when a copy of an existing object is
needed. This fixes a memory leak in Cache::do_get_info.
2020-03-09 07:51:08 +02:00
6f45545e09
Fix call command
memory leak
...
The module command arguments were never freed.
2020-03-09 07:38:53 +02:00
3da2580f09
Fix list modules
memory leak
...
The wrong JSON function was used: the one without the _new suffix will
copy the memory.
2020-03-09 07:31:49 +02:00
2bb914b21e
Fix param_type_to_str
...
Duration wasn't in the switch. Removing the default case allows this to be
detected at compile time.
2020-03-09 07:23:52 +02:00
eb0432b7b2
MXS-2860: Extract socket error only when needed
...
As the process of extracting the socket error also resets it, it should be
done only when necessary.
2020-03-06 13:56:42 +02:00
318a81121b
Fix multi-host usage of maxctrl
...
The credentials weren't passed to all the hosts.
2020-03-06 13:23:55 +02:00
5b45796da4
Add missing maxctrl test cases
...
Code coverage revealed that some parts of the code could be easily
tested. Added these missing test cases and removed some dead code.
2020-03-05 21:13:39 +02:00
68c070c2c4
Update maxctrl packages
...
Updated packages to fix vulnerabilities reported by npm. The yargs package
was not updated as it introduces changes that aren't backwards compatible.
2020-03-05 21:13:39 +02:00
9eceeffc04
MXS-2811: Set TLS version with MARIADB_OPT_TLS_VERSION
...
The ssl_version values now also affect the TLS version used by the
connector.
2020-03-05 21:13:38 +02:00
fda12c0cb2
Merge branch '2.3' into 2.4
2020-03-05 15:00:37 +02:00
6aab4ed416
MXS-2893: Fix parameter validation
...
The code assumed all parameters were string values. Encasing the code in a
try-catch block solves it.
2020-03-05 09:06:36 +02:00
1bf46fadf6
MXS-2891: Log password hash on mismatch
...
By logging the password hash when user authentication fails due to a
password mismatch, we can be certain what the client sent and what is the
currently stored value in MaxScale. This should not be on by default which
is why a new parameter is required.
2020-03-04 17:11:34 +02:00
4a2d3dc55b
MXS-2914 Link to pcre2 syntax page instead of API page
...
More appropriate link.
2020-03-04 16:38:18 +02:00
0aae500577
MXS-2898 Classify @@last_insert_id() and last_insert_id() identically
...
With this change, both 'SET @my_id = (SELECT LAST_INSERT_ID())' and
'SET @my_id = (SELECT @@LAST_INSERT_ID)' are classified as
QUERY_TYPE_MASTER_READ|QUERY_TYPE_SESSION_WRITE|QUERY_TYPE_USERVAR_WRITE
Earlier @@last_insert_id had the QUERY_TYPE_READ bit set as well, which
indirectly caused the problems of MXS-2898.
2020-03-04 13:18:09 +02:00
4c2909e86c
MXS-2227 Fix problem, parse OPTIMIZE statements
...
OPTIMIZE [NO_WRITE_TO_BINLOG | LOCAL] TABLE
tbl_name [, tbl_name] ...
[WAIT n | NOWAIT]
2020-03-04 13:10:46 +02:00
3df8429db3
MXS-2227 Add test that reveals problem
2020-03-04 13:10:46 +02:00
fda3cf8160
Merge branch '2.3' into 2.4
2020-03-04 09:10:28 +02:00
61fc3d8a42
MXS-2907: Fix logrotate script
...
The SIGUSR1 isn't sent if the PID file is not found as that means MaxScale
is not running.
2020-03-04 09:07:50 +02:00
2f6d003491
MXS-2832: Document failover timing estimates
...
The worst-case time it takes for failover to start is now documented.
2020-03-04 08:49:03 +02:00
ee8e43f26b
MXS-2508 Fix problem
...
DIV and MOD are now also accepted instead of / and % respectively.
MOD is a keyword but (in principle incorrectly) decays into an id
when used in some other context. That is so that it will be
parser by the general function rule ("id ( ... )"). If used
incorrectly, the server will later reject.
2020-03-03 11:30:58 +02:00
be3be3bf99
MXS-2508 Add test that reveals problem
2020-03-03 11:30:58 +02:00
f66d7ca838
MXS-2508 Fix qc_mysqlembedded
...
It appears that the function db_my_assert may be used but not
built into the library.
With 10.4.12 there seem to occasionally be superfluous empty
table names.
2020-03-03 11:30:58 +02:00
4a5293ebba
Merge branch '2.3' into 2.4
2020-03-02 18:05:11 +02:00
e2e220de66
MXS-2726: Document ccrfilter default behavior
...
Added an explicit mention of the way the filter works.
2020-03-02 17:30:11 +02:00
b23edeb111
MXS-2832: Document failover timing estimates
...
The worst-case time it takes for failover to start is now documented.
2020-03-02 17:30:11 +02:00
b7d0be97ab
MXS-2211: Auto-generate TOC
...
The link no longer works as the section has been removed. Auto-generating
the TOC solves this.
2020-03-02 17:30:10 +02:00
207882defb
MXS-2277: Document script limitations
...
The script should not interact with the administrative interfaces of
MaxScale.
2020-03-02 17:30:10 +02:00
67fee60f80
Fix Auth Error server status
...
The mon_ping_or_connect_to_db resets the MYSQL handle which caused the
loss of the error message. Returning a new enumeration value for
authentication errors solves this problem.
2020-03-02 16:32:35 +02:00
84f091987b
Merge branch '2.3' into 2.4
2020-03-02 14:19:27 +02:00
4e5d9099ed
Merge commit 'e180c200555576cc1f9bfc77342abba422934e4a' into 2.4
2020-03-02 12:51:57 +02:00
96ba2da40c
MXS-2900 Move testcore library files to a dedicated directory
...
The library is now named "maxtest". The related include-files are, for
now, usable without designating the full include path. This may be changed
later, but would require modifying every test.
2020-03-02 11:17:30 +02:00
e180c20055
MXS-2899: Update charset only when successful
...
By updating the server charset only when we successfully query it, the
charset will not change due to network connectivity problems.
2020-02-27 14:18:51 +02:00
9ca2c7f777
Merge branch '2.3' into 2.4
2020-02-24 14:10:19 +02:00
0614a44a4d
Add monitor TLS test case
...
Added a test that verifies the server state is Down when the backend
doesn't support TLS.
2020-02-24 12:02:50 +02:00
b241f7ed2a
MXS-2896: Fix monitor connection creation
...
The connection is now correctly null after a failed attempt to connect.
2020-02-24 12:02:50 +02:00
13658fe23e
MXS-2810: Fix CentOS 6 regression
...
MaxScale wasn't stopped if the system didn't use systemd.
2020-02-24 12:02:50 +02:00
19030bed35
Merge branch '2.3' into 2.4
2020-02-19 19:25:40 +02:00
61050ed125
Fix Avro C API link
...
The old link is dead.
2020-02-19 19:24:39 +02:00
c1fc7bd742
Document avrorouter diagnostic output
2020-02-18 14:26:29 +02:00
be508fe5d9
MXS-2873: Document more router diagnostics
...
Documented readconnroute and schemarouter router diagnostics. The
duplicated fields that are already in the general service diagnostic
output are not documented with the hopes that they can be eventually
removed.
2020-02-18 09:45:02 +02:00
2bc2ab2196
MXS-2873: Document readwritesplit router diagnostics
...
The REST API output is now documented in the router documentation. The
same will be done for other routers as well.
2020-02-18 09:23:13 +02:00
cb96725a51
MXS-2382: Add TLS setup into server tutorial
...
Given the recent fixes to the TLS configuration, the process of enabling
TLS is rather simple.
2020-02-17 20:15:43 +02:00
405b10ad50
Fix server TLS regression
...
The code in 2.3 was changed to allow "empty" SSL definitions now that the
system CA is used. The code in 2.4 did not allow this which caused non-TLS
connections to be created when only ssl=true was defined.
2020-02-17 20:03:35 +02:00
5842242e94
Fix debug assert on SSL with system CA
...
The debug assertion was not updated in the merge.
2020-02-17 20:03:35 +02:00
912cb711e3
MXS-2844: Fix binlogrouter destruction
...
Binlogrouter services can now be destroyed at runtime.
2020-02-14 08:55:48 +02:00
a09f291249
Merge branch '2.4.7' into 2.4
2020-02-13 14:51:04 +02:00
ef659b94a6
Update 2.4.7 release date
2020-02-13 14:39:45 +02:00