415c7fa2d7
Fix comments. Fix a bug in make_valid(). Change sync time (when the average should be pushed to the server EMA) to only depend on time, not use sample_max. This decreases the amount of sync calls, and allows for a much shorter sync time. Testing shows this to be more stabel and allows to make sample_max adaptive .
103 lines
2.5 KiB
C++
103 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2016 MariaDB Corporation Ab
|
|
*
|
|
* Use of this software is governed by the Business Source License included
|
|
* in the LICENSE.TXT file and at www.mariadb.com/bsl11.
|
|
*
|
|
* Change Date: 2022-01-01
|
|
*
|
|
* On the date above, in accordance with the Business Source License, use
|
|
* of this software will be governed by version 2 or later of the General
|
|
* Public License.
|
|
*/
|
|
#include <maxscale/response_stat.hh>
|
|
|
|
#include <algorithm>
|
|
|
|
namespace maxscale
|
|
{
|
|
ResponseStat::ResponseStat(int num_filter_samples,
|
|
maxbase::Duration sync_duration)
|
|
: m_num_filter_samples {num_filter_samples}
|
|
, m_sync_duration{sync_duration}
|
|
, m_sample_count{0}
|
|
, m_samples(num_filter_samples)
|
|
, m_last_start{maxbase::TimePoint()}
|
|
, m_next_sync{maxbase::Clock::now() + sync_duration}
|
|
{
|
|
}
|
|
|
|
|
|
void ResponseStat::query_started()
|
|
{
|
|
m_last_start = maxbase::Clock::now();
|
|
}
|
|
|
|
void ResponseStat::query_ended()
|
|
{
|
|
if (m_last_start == maxbase::TimePoint())
|
|
{
|
|
// m_last_start is defaulted. Ignore, avoids extra logic at call sites.
|
|
return;
|
|
}
|
|
m_samples[m_sample_count] = maxbase::Clock::now() - m_last_start;
|
|
|
|
if (++m_sample_count == m_num_filter_samples)
|
|
{
|
|
std::sort(m_samples.begin(), m_samples.end());
|
|
maxbase::Duration new_sample = m_samples[m_num_filter_samples / 2];
|
|
m_average.add(std::chrono::duration<double>(new_sample).count());
|
|
m_sample_count = 0;
|
|
}
|
|
m_last_start = maxbase::TimePoint();
|
|
}
|
|
|
|
bool ResponseStat::make_valid()
|
|
{
|
|
if (!m_average.num_samples() && m_sample_count)
|
|
{
|
|
std::sort(m_samples.begin(), m_samples.begin() + m_sample_count);
|
|
maxbase::Duration new_sample = m_samples[m_sample_count / 2];
|
|
m_average.add(std::chrono::duration<double>(new_sample).count());
|
|
m_sample_count = 0;
|
|
m_last_start = maxbase::TimePoint();
|
|
}
|
|
|
|
return is_valid();
|
|
}
|
|
|
|
bool ResponseStat::is_valid() const
|
|
{
|
|
return m_average.num_samples();
|
|
}
|
|
|
|
int ResponseStat::num_samples() const
|
|
{
|
|
return m_average.num_samples();
|
|
}
|
|
|
|
maxbase::Duration ResponseStat::average() const
|
|
{
|
|
return maxbase::Duration(m_average.average());
|
|
}
|
|
|
|
bool ResponseStat::sync_time_reached()
|
|
{
|
|
auto now = maxbase::Clock::now();
|
|
bool reached = m_next_sync < now;
|
|
|
|
if (reached)
|
|
{
|
|
m_next_sync = now + m_sync_duration;
|
|
}
|
|
return reached;
|
|
}
|
|
|
|
void ResponseStat::reset()
|
|
{
|
|
m_sample_count = 0;
|
|
m_average.reset();
|
|
m_next_sync = maxbase::Clock::now() + m_sync_duration;
|
|
}
|
|
}
|