 de49797014
			
		
	
	de49797014
	
	
	
		
			
			Rewrote the bug561.sh test as the error_messages test that covers what was tested by the script as well as some new parts that were untested. This revealed a bug in the error messages where MaxScale always returns the database name in the error.
		
			
				
	
	
		
			111 lines
		
	
	
		
			4.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			111 lines
		
	
	
		
			4.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /**
 | |
|  * Regression case for the bug "Different error messages from MariaDB and Maxscale"
 | |
|  *
 | |
|  * - try to connect to non existing DB directly to MariaDB server and via Maxscale
 | |
|  * - compare error messages
 | |
|  * - repeat for RWSplit, ReadConn
 | |
|  */
 | |
| 
 | |
| #include "testconnections.h"
 | |
| #include <iostream>
 | |
| #include <algorithm>
 | |
| 
 | |
| using std::cout;
 | |
| using std::endl;
 | |
| 
 | |
| std::string remove_host(std::string str)
 | |
| {
 | |
|     auto start = std::find(str.begin(), str.end(), '@');
 | |
|     if (start != str.end())
 | |
|     {
 | |
|         start += 2;
 | |
|         auto end = std::find(start, str.end(), '\'');
 | |
|         if (end != str.end())
 | |
|         {
 | |
|             str.erase(start, end);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     return str;
 | |
| }
 | |
| 
 | |
| 
 | |
| bool is_equal_error(MYSQL* direct, MYSQL* conn)
 | |
| {
 | |
|     bool rval = true;
 | |
|     std::string direct_err = remove_host(mysql_error(direct));
 | |
|     std::string conn_err = remove_host(mysql_error(conn));
 | |
| 
 | |
|     if (direct_err != conn_err)
 | |
|     {
 | |
|         rval = false;
 | |
|         cout << "Wrong error: `" << conn_err << "` (original: `" << direct_err << "`)" << endl;
 | |
|     }
 | |
| 
 | |
|     return rval;
 | |
| }
 | |
| 
 | |
| int main(int argc, char** argv)
 | |
| {
 | |
|     TestConnections test(argc, argv);
 | |
| 
 | |
|     cout << "Non-existent database" << endl;
 | |
|     test.repl->connect(0, "non_existing_db");
 | |
|     test.maxscales->connect(0,  "non_existing_db");
 | |
|     test.expect(is_equal_error(test.repl->nodes[0], test.maxscales->conn_rwsplit[0]), "readwritesplit returned wrong error");
 | |
|     test.expect(is_equal_error(test.repl->nodes[0], test.maxscales->conn_master[0]), "readconnroute returned wrong error");
 | |
|     test.repl->disconnect();
 | |
|     test.maxscales->disconnect();
 | |
| 
 | |
|     cout << "Non-existent user" << endl;
 | |
|     auto conn_direct = open_conn(test.repl->port[0], test.repl->IP[0], "not-a-user", "not-a-password", false);
 | |
|     auto conn_rwsplit = open_conn(test.maxscales->rwsplit_port[0], test.maxscales->IP[0], "not-a-user", "not-a-password", false);
 | |
|     auto conn_rconn = open_conn(test.maxscales->rwsplit_port[0], test.maxscales->IP[0], "not-a-user", "not-a-password", false);
 | |
| 
 | |
|     test.expect(is_equal_error(conn_direct, conn_rwsplit), "readwritesplit returned wrong error");
 | |
|     test.expect(is_equal_error(conn_direct, conn_rconn), "readconnroute returned wrong error");
 | |
| 
 | |
|     mysql_close(conn_direct);
 | |
|     mysql_close(conn_rwsplit);
 | |
|     mysql_close(conn_rconn);
 | |
| 
 | |
|     cout << "Wrong password" << endl;
 | |
|     conn_direct = open_conn(test.repl->port[0], test.repl->IP[0], "skysql", "not-a-password", false);
 | |
|     conn_rwsplit = open_conn(test.maxscales->rwsplit_port[0], test.maxscales->IP[0], "skysql", "not-a-password", false);
 | |
|     conn_rconn = open_conn(test.maxscales->rwsplit_port[0], test.maxscales->IP[0], "skysql", "not-a-password", false);
 | |
| 
 | |
|     test.expect(is_equal_error(conn_direct, conn_rwsplit), "readwritesplit returned wrong error");
 | |
|     test.expect(is_equal_error(conn_direct, conn_rconn), "readconnroute returned wrong error");
 | |
| 
 | |
|     mysql_close(conn_direct);
 | |
|     mysql_close(conn_rwsplit);
 | |
|     mysql_close(conn_rconn);
 | |
| 
 | |
|     // Create a database and a user without access to it
 | |
|     test.repl->connect();
 | |
|     test.try_query(test.repl->nodes[0], "%s", "CREATE USER 'bob'@'%' IDENTIFIED BY 's3cret'");
 | |
|     test.try_query(test.repl->nodes[0], "%s", "CREATE DATABASE error_messages");
 | |
|     test.repl->sync_slaves();
 | |
|     test.repl->disconnect();
 | |
| 
 | |
|     cout << "No permissions on database" << endl;
 | |
|     conn_direct = open_conn_db(test.repl->port[0], test.repl->IP[0], "error_messages", "bob", "s3cret", false);
 | |
|     conn_rwsplit = open_conn_db(test.maxscales->rwsplit_port[0], test.maxscales->IP[0], "error_messages", "bob", "s3cret", false);
 | |
|     conn_rconn = open_conn_db(test.maxscales->rwsplit_port[0], test.maxscales->IP[0], "error_messages", "bob", "s3cret", false);
 | |
| 
 | |
|     test.expect(is_equal_error(conn_direct, conn_rwsplit), "readwritesplit returned wrong error");
 | |
|     test.expect(is_equal_error(conn_direct, conn_rconn), "readconnroute returned wrong error");
 | |
| 
 | |
|     mysql_close(conn_direct);
 | |
|     mysql_close(conn_rwsplit);
 | |
|     mysql_close(conn_rconn);
 | |
| 
 | |
|     // Create a database and a user without access to it
 | |
|     test.repl->connect();
 | |
|     test.try_query(test.repl->nodes[0], "%s", "DROP USER 'bob'@'%'");
 | |
|     test.try_query(test.repl->nodes[0], "%s", "DROP DATABASE error_messages");
 | |
|     test.repl->disconnect();
 | |
| 
 | |
|     return test.global_result;
 | |
| }
 |