hcq/influx-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(api): improve codegen outputs (#41)

Browse Source 
* Use `[]byte` for generated request bodies when the source schema has `format: byte`
* Gzip-compress request bodies when `Content-Encoding: gzip` is set
* Require that all models returned as error conditions in our API implement the `error` interface
* Move the implementation for `api.HealthCheck` out of `ping.go` and into `api/error.go`


Co-authored-by: William Baker <55118525+wbaker85@users.noreply.github.com>
This commit is contained in:
Daniel Moran
2021-04-26 10:10:45 -04:00
committed by GitHub
parent 5328b1fdc8
commit 73dc5ef63b
11 changed files with 147 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
internal/ping.go
View File

@ -2,7 +2,6 @@ package internal
import (
"context"
"fmt"
"github.com/influxdata/influx-cli/v2/internal/api"
)
@ -13,21 +12,10 @@ func (c *CLI) Ping(ctx context.Context, client api.HealthApi) error {
if c.TraceId != "" {
req = req.ZapTraceSpan(c.TraceId)
}
resp, _, err := client.GetHealthExecute(req)
if err != nil {
return fmt.Errorf("failed to make health check request: %w", err)
if _, _, err := client.GetHealthExecute(req); err != nil {
return err
}
if resp.Status == api.HEALTHCHECKSTATUS_FAIL {
var message string
if resp.Message != nil {
message = *resp.Message
} else {
message = fmt.Sprintf("check %s failed", resp.Name)
}
return fmt.Errorf("health check failed: %s", message)
}
_, err = c.StdIO.Write([]byte("OK\n"))
_, err := c.StdIO.Write([]byte("OK\n"))
return err
}