From 85c690f1f1d0107f0e2448c2b49db563c6851a7f Mon Sep 17 00:00:00 2001 From: Dane Strandboge Date: Thu, 23 Jun 2022 10:07:38 -0500 Subject: [PATCH] chore: add checkgenerate test to `lint` (#404) --- .circleci/config.yml | 4 ++++ Makefile | 3 +++ etc/checkgenerate.sh | 16 ++++++++++++++++ 3 files changed, 23 insertions(+) create mode 100755 etc/checkgenerate.sh diff --git a/.circleci/config.yml b/.circleci/config.yml index 484d12e..679f6d1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -274,6 +274,10 @@ jobs: name: staticcheck command: make staticcheck when: always + - run: + name: Check generate + command: make checkgenerate + when: always check-openapi: executor: linux-amd64 diff --git a/Makefile b/Makefile index bde32f6..b5891d5 100644 --- a/Makefile +++ b/Makefile @@ -64,6 +64,9 @@ checktidy: checkopenapi: ./etc/checkopenapi.sh +checkgenerate: + ./etc/checkgenerate.sh + staticcheck: $(SOURCES) go run honnef.co/go/tools/cmd/staticcheck -go $(GOVERSION) ./... diff --git a/etc/checkgenerate.sh b/etc/checkgenerate.sh new file mode 100755 index 0000000..8c59794 --- /dev/null +++ b/etc/checkgenerate.sh @@ -0,0 +1,16 @@ +#!/bin/bash + +set -e + +function check_changes () { + changes="$(git status --porcelain=v1 2>/dev/null)" + if [ -n "$changes" ] ; then + echo $1 + echo "$changes" + exit 1 + fi +} + +check_changes "git is dirty before running 'make generate-sources!'" +make mock +check_changes "git is dirty after running 'make generate-sources'!"