hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

RTDatumArith memory leak

Browse Source
This commit is contained in:
obdev
2023-04-26 14:45:15 +00:00
committed by ob-robot
parent 8bb757b90f
commit 03f103d18a
1 changed files with 28 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/sql/engine/aggregate/ob_aggregate_processor.cpp
View File

@ -618,13 +618,34 @@ int ObAggregateProcessor::init()
if (T_FUN_MEDIAN == aggr_info.get_expr_type() if (T_FUN_MEDIAN == aggr_info.get_expr_type()
|| T_FUN_GROUP_PERCENTILE_CONT == aggr_info.get_expr_type()) { || T_FUN_GROUP_PERCENTILE_CONT == aggr_info.get_expr_type()) {
LinearInterAggrFuncCtx *ctx = OB_NEWx(LinearInterAggrFuncCtx, // ObAggregateProcessor::init would be invoked many times under groupby rescan
(&eval_ctx_.exec_ctx_.get_allocator())); // Only create LinearInterAggrFuncCtx once to prevent memory leak.
if (NULL == ctx) { //
ret = OB_ALLOCATE_MEMORY_FAILED; // Details:
LOG_WARN("allocate memory failed", K(ret)); // Normally ObAggregateProcessor::init would ONLY be invoked once under open
} else { // stage and NEVER be triggered any more. Typically window function follows
aggr_func_ctxs_.at(i) = ctx; // this rule.
// However, ObAggregateProcessor::init would be invoked many times under groupby
// rescan cases, see ObGroupByOp::inner_rescan. And LinearInterAggrFuncCtx would
// be created repeatedly. This break init semantic(invoked once) and leading
// memory leak.
//
// Solution:
// Only create LinearInterAggrFuncCtx once when ObAggregateProcessor::init is called
// repeatedly. So both window function and groupby cases would be well handled.
//
// TODO qubin.qb:
// Refactor group by rescan API to stop calling ObAggregateProcessor::init so that
// init semantic (only invoke one time) would be strictly followed
if (aggr_func_ctxs_.at(i) == nullptr) {
LinearInterAggrFuncCtx *ctx = OB_NEWx(LinearInterAggrFuncCtx,
(&eval_ctx_.exec_ctx_.get_allocator()));
if (NULL == ctx) {
ret = OB_ALLOCATE_MEMORY_FAILED;
LOG_WARN("allocate memory failed", K(ret));
} else {
aggr_func_ctxs_.at(i) = ctx;
}
} }
} }
} }