hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix debug log for log cache read failure.

Browse Source
This commit is contained in:
jiadebinmary@gmail.com
2023-05-17 17:16:32 +00:00
committed by ob-robot
parent e7cd0c9a7c
commit 061edc781d
3 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/logservice/palf/log_cache.cpp
View File

@ -78,8 +78,10 @@ int LogHotCache::read(const LSN &read_begin_lsn,
KP(buf)); KP(buf));
} else if (OB_FAIL(palf_handle_impl_->read_data_from_buffer(read_begin_lsn, in_read_size, \ } else if (OB_FAIL(palf_handle_impl_->read_data_from_buffer(read_begin_lsn, in_read_size, \
buf, out_read_size))) { buf, out_read_size))) {
PALF_LOG(WARN, "read_data_from_buffer failed", K(ret), K_(palf_id), K(read_begin_lsn), if (OB_ERR_OUT_OF_LOWER_BOUND != ret) {
K(in_read_size)); PALF_LOG(WARN, "read_data_from_buffer failed", K(ret), K_(palf_id), K(read_begin_lsn),
K(in_read_size));
}
} else { } else {
hit_cnt = ATOMIC_AAF(&hit_count_, 1); hit_cnt = ATOMIC_AAF(&hit_count_, 1);
read_size = ATOMIC_AAF(&read_size_, out_read_size); read_size = ATOMIC_AAF(&read_size_, out_read_size);

4
src/logservice/palf/log_sliding_window.cpp
View File

@ -4376,7 +4376,9 @@ int LogSlidingWindow::read_data_from_buffer(const LSN &read_begin_lsn,
} else { } else {
RLockGuard guard(group_buffer_lock_); // protect group_buffer_ from destroy by flashback(). RLockGuard guard(group_buffer_lock_); // protect group_buffer_ from destroy by flashback().
if (OB_FAIL(group_buffer_.read_data(read_begin_lsn, in_read_size, buf, out_read_size))) { if (OB_FAIL(group_buffer_.read_data(read_begin_lsn, in_read_size, buf, out_read_size))) {
PALF_LOG(WARN, "read_data failed", K(ret), K_(palf_id), K(read_begin_lsn), K(in_read_size)); if (OB_ERR_OUT_OF_LOWER_BOUND != ret) {
PALF_LOG(WARN, "read_data failed", K(ret), K_(palf_id), K(read_begin_lsn), K(in_read_size));
}
} else { } else {
PALF_LOG(TRACE, "read_data_from_buffer success", K(ret), K_(palf_id), K(read_begin_lsn), PALF_LOG(TRACE, "read_data_from_buffer success", K(ret), K_(palf_id), K(read_begin_lsn),
K(in_read_size), K(out_read_size)); K(in_read_size), K(out_read_size));

6
src/logservice/palf/palf_handle_impl.cpp
View File

@ -4666,8 +4666,10 @@ int PalfHandleImpl::read_data_from_buffer(const LSN &read_begin_lsn,
PALF_LOG(WARN, "invalid arguments", K(ret), K_(palf_id), K(read_begin_lsn), K(in_read_size), PALF_LOG(WARN, "invalid arguments", K(ret), K_(palf_id), K(read_begin_lsn), K(in_read_size),
KP(buf)); KP(buf));
} else if (OB_FAIL(sw_.read_data_from_buffer(read_begin_lsn, in_read_size, buf, out_read_size))) { } else if (OB_FAIL(sw_.read_data_from_buffer(read_begin_lsn, in_read_size, buf, out_read_size))) {
PALF_LOG(WARN, "read_data_from_buffer failed", K(ret), K_(palf_id), K(read_begin_lsn), if (OB_ERR_OUT_OF_LOWER_BOUND != ret) {
K(in_read_size)); PALF_LOG(WARN, "read_data_from_buffer failed", K(ret), K_(palf_id), K(read_begin_lsn),
K(in_read_size));
}
} else { } else {
PALF_LOG(TRACE, "read_data_from_buffer success", K(ret), K_(palf_id), K(read_begin_lsn), PALF_LOG(TRACE, "read_data_from_buffer success", K(ret), K_(palf_id), K(read_begin_lsn),
K(in_read_size), K(out_read_size)); K(in_read_size), K(out_read_size));