hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

remove some todo

Browse Source
This commit is contained in:
oceanoverflow
2023-07-25 02:48:31 +00:00
committed by ob-robot
parent 68bd17a753
commit 08e527e5dd
5 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/storage/high_availability/ob_storage_ha_struct.cpp
View File

@ -999,7 +999,6 @@ bool ObCopyTableKeyInfo::operator ==(const ObCopyTableKeyInfo &other) const
OB_SERIALIZE_MEMBER(ObCopyTableKeyInfo, src_table_key_, dest_table_key_); OB_SERIALIZE_MEMBER(ObCopyTableKeyInfo, src_table_key_, dest_table_key_);
/******************ObCopyMacroRangeInfo*********************/ /******************ObCopyMacroRangeInfo*********************/
//TODO(yanfeng) check endkey in 4.1
ObCopyMacroRangeInfo::ObCopyMacroRangeInfo() ObCopyMacroRangeInfo::ObCopyMacroRangeInfo()
: start_macro_block_id_(), : start_macro_block_id_(),
end_macro_block_id_(), end_macro_block_id_(),

1
src/storage/high_availability/ob_tablet_group_restore.cpp
View File

@ -1854,7 +1854,6 @@ int ObTabletRestoreDag::init(
tablet_restore_ctx_.is_leader_ = param.is_leader_; tablet_restore_ctx_.is_leader_ = param.is_leader_;
tablet_restore_ctx_.meta_index_store_ = param.meta_index_store_; tablet_restore_ctx_.meta_index_store_ = param.meta_index_store_;
tablet_restore_ctx_.second_meta_index_store_ = param.second_meta_index_store_; tablet_restore_ctx_.second_meta_index_store_ = param.second_meta_index_store_;
// TODO: yanfeng make sure this is right
tablet_restore_ctx_.replica_type_ = REPLICA_TYPE_FULL; tablet_restore_ctx_.replica_type_ = REPLICA_TYPE_FULL;
tablet_restore_ctx_.ha_table_info_mgr_ = param.ha_table_info_mgr_; tablet_restore_ctx_.ha_table_info_mgr_ = param.ha_table_info_mgr_;
tablet_restore_ctx_.need_check_seq_ = param.need_check_seq_; tablet_restore_ctx_.need_check_seq_ = param.need_check_seq_;

2
src/storage/ls/ob_ls.h
View File

@ -657,7 +657,7 @@ public:
DELEGATE_WITH_RET(member_list_service_, replace_member, int); DELEGATE_WITH_RET(member_list_service_, replace_member, int);
DELEGATE_WITH_RET(member_list_service_, replace_member_with_learner, int); DELEGATE_WITH_RET(member_list_service_, replace_member_with_learner, int);
DELEGATE_WITH_RET(member_list_service_, get_config_version_and_transfer_scn, int); DELEGATE_WITH_RET(member_list_service_, get_config_version_and_transfer_scn, int);
DELEGATE_WITH_RET(log_handler_, add_learner, int); //TODO(yanfeng): fix it DELEGATE_WITH_RET(log_handler_, add_learner, int);
DELEGATE_WITH_RET(log_handler_, replace_learners, int); DELEGATE_WITH_RET(log_handler_, replace_learners, int);
DELEGATE_WITH_RET(block_tx_service_, ha_block_tx, int); DELEGATE_WITH_RET(block_tx_service_, ha_block_tx, int);
DELEGATE_WITH_RET(block_tx_service_, ha_kill_tx, int); DELEGATE_WITH_RET(block_tx_service_, ha_kill_tx, int);

2
src/storage/ob_storage_rpc.h
View File

@ -47,7 +47,7 @@ class ObLogStreamService;
namespace obrpc namespace obrpc
{ {
//TODO(yanfeng) need use tenant module replace it in 4.1, currently use 509 tenant //TODO(yanfeng) need use tenant module replace it in 4.3, currently use 509 tenant
struct ObCopyMacroBlockArg struct ObCopyMacroBlockArg
{ {

1
src/storage/ob_value_row_iterator.cpp
View File

@ -173,7 +173,6 @@ int ObSingleRowGetter::init_dml_access_ctx(
if (skip_read_lob) { if (skip_read_lob) {
query_flag.skip_read_lob_ = ObQueryFlag::OBSF_MASK_SKIP_READ_LOB; query_flag.skip_read_lob_ = ObQueryFlag::OBSF_MASK_SKIP_READ_LOB;
} }
//TODO (yanfeng) trans_version_range值后续由上层传入
trans_version_range.snapshot_version_ = store_ctx.mvcc_acc_ctx_.get_snapshot_version().get_val_for_tx(); trans_version_range.snapshot_version_ = store_ctx.mvcc_acc_ctx_.get_snapshot_version().get_val_for_tx();
trans_version_range.base_version_ = 0; trans_version_range.base_version_ = 0;
trans_version_range.multi_version_start_ = 0; trans_version_range.multi_version_start_ = 0;