hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix temp table transform bug

Browse Source
This commit is contained in:
zzg19950727
2023-02-24 14:23:45 +00:00
committed by ob-robot
parent f0049f09e5
commit 11dc664903
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sql/rewrite/ob_transform_temp_table.cpp
View File

@ -504,16 +504,13 @@ int ObTransformTempTable::inner_extract_common_subquery_as_cte(ObDMLStmt &root_s
//对每组相似stmt创建temp table //对每组相似stmt创建temp table
for (int64_t i = 0; OB_SUCC(ret) && i < compare_info.count(); ++i) { for (int64_t i = 0; OB_SUCC(ret) && i < compare_info.count(); ++i) {
StmtCompareHelper &helper = compare_info.at(i); StmtCompareHelper &helper = compare_info.at(i);
bool is_valid = false;
OPT_TRACE("try to materialize:", helper.stmt_); OPT_TRACE("try to materialize:", helper.stmt_);
if (!helper.hint_force_stmt_set_.empty() && if (!helper.hint_force_stmt_set_.empty() &&
!helper.hint_force_stmt_set_.is_equal(helper.similar_stmts_)) { !helper.hint_force_stmt_set_.is_equal(helper.similar_stmts_)) {
//hint forbid, do nothing //hint forbid, do nothing
OPT_TRACE("hint reject transform"); OPT_TRACE("hint reject transform");
} else if (OB_FAIL(check_stmt_can_materialize(helper.stmt_, is_valid))) {
LOG_WARN("failed to check stmt is valid", K(ret));
} else if (helper.hint_force_stmt_set_.empty() && } else if (helper.hint_force_stmt_set_.empty() &&
(helper.similar_stmts_.count() < 2 || !is_valid)) { (helper.similar_stmts_.count() < 2)) {
//do nothing //do nothing
} else if (OB_FAIL(create_temp_table(helper))) { } else if (OB_FAIL(create_temp_table(helper))) {
LOG_WARN("failed to create temp table", K(ret)); LOG_WARN("failed to create temp table", K(ret));
@ -700,6 +697,7 @@ int ObTransformTempTable::remove_simple_stmts(ObIArray<ObSelectStmt*> &stmts)
int ret = OB_SUCCESS; int ret = OB_SUCCESS;
ObSEArray<ObSelectStmt*, 8> new_stmts; ObSEArray<ObSelectStmt*, 8> new_stmts;
bool has_rownum = false; bool has_rownum = false;
bool is_valid = false;
for (int64_t i = 0; OB_SUCC(ret) && i < stmts.count(); ++i) { for (int64_t i = 0; OB_SUCC(ret) && i < stmts.count(); ++i) {
ObSelectStmt *subquery = stmts.at(i); ObSelectStmt *subquery = stmts.at(i);
if (OB_ISNULL(subquery)) { if (OB_ISNULL(subquery)) {
@ -711,6 +709,10 @@ int ObTransformTempTable::remove_simple_stmts(ObIArray<ObSelectStmt*> &stmts)
//do nothing //do nothing
} else if (ObOptimizerUtil::find_item(ctx_->temp_table_ignore_stmts_, subquery)) { } else if (ObOptimizerUtil::find_item(ctx_->temp_table_ignore_stmts_, subquery)) {
//do nothing //do nothing
} else if (OB_FAIL(check_stmt_can_materialize(subquery, is_valid))) {
LOG_WARN("failed to check stmt is valid", K(ret));
} else if (!is_valid) {
//do nothing
} else if (OB_FAIL(new_stmts.push_back(subquery))) { } else if (OB_FAIL(new_stmts.push_back(subquery))) {
LOG_WARN("failed to push back stmt", K(ret)); LOG_WARN("failed to push back stmt", K(ret));
} }