From fbfb1f22345565178e174f852666f496fad6f062 Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Thu, 2 Sep 2021 16:21:24 +0800 Subject: [PATCH 01/10] correct spelling --- src/sql/ob_sql_trans_control.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/ob_sql_trans_control.cpp b/src/sql/ob_sql_trans_control.cpp index 52fb7a1bb7..4049895440 100644 --- a/src/sql/ob_sql_trans_control.cpp +++ b/src/sql/ob_sql_trans_control.cpp @@ -678,7 +678,7 @@ int ObSqlTransControl::stmt_setup_snapshot_(ObSQLSessionInfo *session, } else { snapshot.init_weak_read(snapshot_version); } - // 1) acquire snapshot verison when insert operator is executed + // 1) acquire snapshot version when insert operator is executed // 2) don't resolve RR and SERIALIZABLE isolation scenario temporarily, because of remote stmt plan } else if (plan->is_plain_insert() && session->get_tx_isolation() != ObTxIsolationLevel::SERIAL From 9e3909e71e64da7db85490556e3194fd7be3d98b Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Sat, 2 Oct 2021 16:21:24 +0800 Subject: [PATCH 02/10] correct spelling --- src/sql/plan_cache/ob_cache_object.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/plan_cache/ob_cache_object.cpp b/src/sql/plan_cache/ob_cache_object.cpp index 0454c99abd..5047f6fc19 100644 --- a/src/sql/plan_cache/ob_cache_object.cpp +++ b/src/sql/plan_cache/ob_cache_object.cpp @@ -157,7 +157,7 @@ int ObPlanCacheObject::check_pre_calc_cons(const bool is_ignore_stmt, ObSEArray datum_params; if (OB_ISNULL(phy_plan_ctx)) { ret = OB_ERR_UNEXPECTED; - LOG_WARN("invalid phyiscal plan ctx", K(ret), K(phy_plan_ctx)); + LOG_WARN("invalid physical plan ctx", K(ret), K(phy_plan_ctx)); } else if (OB_FALSE_IT(phy_plan_ctx->set_ignore_stmt(is_ignore_stmt))) { } else if (PRE_CALC_ERROR == expect_res) { if (OB_FAIL(pre_calc_frame.eval_expect_err(exec_ctx, is_match))) { From 9d1dd6f59639b9db83c5a4fa1dec544c61405a1b Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Thu, 2 Dec 2021 16:21:24 +0800 Subject: [PATCH 03/10] correct spelling --- src/sql/plan_cache/ob_plan_cache_util.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/plan_cache/ob_plan_cache_util.cpp b/src/sql/plan_cache/ob_plan_cache_util.cpp index f3456f7c8f..cf088c74b2 100644 --- a/src/sql/plan_cache/ob_plan_cache_util.cpp +++ b/src/sql/plan_cache/ob_plan_cache_util.cpp @@ -251,7 +251,7 @@ int ObPhyLocationGetter::reselect_duplicate_table_best_replica(const ObIArray &table_locations, const ObPlanCacheCtx &pc_ctx, ObIArray &candi_table_locs, From a5553a220130c3925e1a52bf727c76471161b81f Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Tue, 4 Jan 2022 16:21:24 +0800 Subject: [PATCH 04/10] correct spelling --- src/sql/plan_cache/ob_plan_cache_util.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/plan_cache/ob_plan_cache_util.cpp b/src/sql/plan_cache/ob_plan_cache_util.cpp index cf088c74b2..9bd5d240c9 100644 --- a/src/sql/plan_cache/ob_plan_cache_util.cpp +++ b/src/sql/plan_cache/ob_plan_cache_util.cpp @@ -295,7 +295,7 @@ int ObPhyLocationGetter::get_phy_locations(const ObIArray &tabl candi_table_loc.set_duplicate_type(table_location.get_duplicate_type()); candi_table_loc.set_table_location_key( table_location.get_table_id(), table_location.get_ref_table_id()); - LOG_DEBUG("plan cache utitl", K(candi_table_loc)); + LOG_DEBUG("plan cache util", K(candi_table_loc)); } if (OB_SUCC(ret)) { if (OB_FAIL(table_location_ptrs.push_back(&table_location))) { From 233f23763ca8f94ea9b2291028b01c1560a4b0f4 Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Fri, 21 Jan 2022 16:21:24 +0800 Subject: [PATCH 05/10] correct spelling --- src/sql/plan_cache/ob_plan_set.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/sql/plan_cache/ob_plan_set.cpp b/src/sql/plan_cache/ob_plan_set.cpp index b1a281099a..12369384db 100644 --- a/src/sql/plan_cache/ob_plan_set.cpp +++ b/src/sql/plan_cache/ob_plan_set.cpp @@ -277,7 +277,7 @@ int ObPlanSet::match_param_info(const ObParamInfo ¶m_info, is_same = false; } else { // number params in point and st_point can ignore scale check to share plancache - // please refrer to ObSqlParameterization::is_ignore_scale_check + // please refer to ObSqlParameterization::is_ignore_scale_check is_same = param_info.flag_.ignore_scale_check_ ? true : (param.get_scale() == param_info.scale_); @@ -734,7 +734,7 @@ int ObPlanSet::init_new_set(const ObPlanCacheCtx &pc_ctx, } } - // init const param constriants + // init const param constraints ObPlanSetType ps_t = get_plan_set_type_by_cache_obj_type(plan.get_ns()); if (PST_PRCD == ps_t) { // pl does not have any const param constraint @@ -928,7 +928,7 @@ int ObPlanSet::match_cons(const ObPlanCacheCtx &pc_ctx, bool &is_matched) OB_ISNULL(equal_cons)) { is_matched = false; ret = OB_INVALID_ARGUMENT; - LOG_WARN("invalid arugment", K(param_cons), K(possible_param_cons), K(equal_cons)); + LOG_WARN("invalid argument", K(param_cons), K(possible_param_cons), K(equal_cons)); } else if (param_cons->count() != all_plan_const_param_constraints_.count() || possible_param_cons->count() != all_possible_const_param_constraints_.count() || equal_cons->count() != all_equal_param_constraints_.count() || @@ -1082,7 +1082,7 @@ int ObPlanSet::init_pre_calc_exprs(const ObPlanCacheObject &phy_plan, void *buf = NULL; if (phy_plan.get_pre_calc_frames().get_size() == 0) { - // have no pre calculable expression, not initalize pre calculable expression handle. + // have no pre calculable expression, not initialize pre calculable expression handle. pre_cal_expr_handler_ = NULL; } else if (OB_ISNULL(pc_alloc_)) { ret = OB_ERR_UNEXPECTED; @@ -1204,7 +1204,7 @@ int ObSqlPlanSet::add_plan(ObPhysicalPlan &plan, candi_table_locs))) { LOG_WARN("fail to get physical locations", K(ret)); } else if (OB_FAIL(set_concurrent_degree(outline_param_idx, plan))) { - LOG_WARN("fail to check oncurrent degree", K(ret)); + LOG_WARN("fail to check concurrent degree", K(ret)); } else { if (pc_ctx.exec_ctx_.get_physical_plan_ctx()->get_or_expand_transformed()) { need_try_plan_ |= TRY_PLAN_OR_EXPAND; @@ -1654,7 +1654,7 @@ int ObSqlPlanSet::get_physical_plan(const ObPhyPlanType plan_type, LOG_WARN("invalid plan type", K(ret), K(plan_type)); } else if (OB_PHY_PLAN_LOCAL == plan_type) { if (OB_FAIL(try_get_local_evolution_plan(pc_ctx, plan, get_next))) { - LOG_WARN("failed to try get local evloution plan", K(ret)); + LOG_WARN("failed to try get local evolution plan", K(ret)); } else if (get_next) { plan = local_plan_; } @@ -1663,7 +1663,7 @@ int ObSqlPlanSet::get_physical_plan(const ObPhyPlanType plan_type, } } else if (OB_PHY_PLAN_DISTRIBUTED == plan_type) { if (OB_FAIL(try_get_dist_evolution_plan(pc_ctx, plan, get_next))) { - LOG_WARN("failed to try get local evloution plan", K(ret)); + LOG_WARN("failed to try get local evolution plan", K(ret)); } else if (get_next && OB_FAIL(dist_plans_.get_plan(pc_ctx, plan))) { LOG_TRACE("failed to get dist plan", K(ret)); } @@ -2027,7 +2027,7 @@ void ObSqlPlanSet::reset() } //get plan used -//need_check_on_same_server: out, 是否需要检查分区在同一sesrver, 如果里面检查过且不在同一server则置为false +//need_check_on_same_server: out, 是否需要检查分区在同一server, 如果里面检查过且不在同一server则置为false int ObSqlPlanSet::get_phy_locations(const ObIArray &table_locations, ObPlanCacheCtx &pc_ctx, ObIArray &candi_table_locs, @@ -2198,7 +2198,7 @@ int ObSqlPlanSet::is_partition_in_same_server(const ObIArray &c } } else { ret = OB_ERR_UNEXPECTED; - SQL_PC_LOG(WARN, "there is no partition_locattion in this phy_location", + SQL_PC_LOG(WARN, "there is no partition_location in this phy_location", K(candi_table_locs.at(i))); } } From a10e3be79197ea73b6fbb3098bb1f0d0f2a69b27 Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Fri, 18 Feb 2022 16:21:24 +0800 Subject: [PATCH 06/10] correct spelling --- src/sql/executor/ob_remote_executor_processor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/executor/ob_remote_executor_processor.cpp b/src/sql/executor/ob_remote_executor_processor.cpp index 9361821f3d..70b16fc1fa 100644 --- a/src/sql/executor/ob_remote_executor_processor.cpp +++ b/src/sql/executor/ob_remote_executor_processor.cpp @@ -768,7 +768,7 @@ int ObRemoteBaseExecuteP::base_before_response(common::ObScanner &scanner) } else { LOG_TRACE("get trans_result", "cur_stmt", session->get_current_query_string(), - "scanner_trans_rsult", scanner.get_trans_result(), + "scanner_trans_result", scanner.get_trans_result(), "tx_desc", *session->get_tx_desc()); } } From cad6e81d30ce95e0a3867b14d75a5833391b3852 Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Wed, 2 Mar 2022 16:21:24 +0800 Subject: [PATCH 07/10] correct spelling --- src/sql/das/ob_das_spatial_index_lookup_op.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/das/ob_das_spatial_index_lookup_op.cpp b/src/sql/das/ob_das_spatial_index_lookup_op.cpp index 07c46aec13..61c08ca27b 100644 --- a/src/sql/das/ob_das_spatial_index_lookup_op.cpp +++ b/src/sql/das/ob_das_spatial_index_lookup_op.cpp @@ -28,7 +28,7 @@ bool ObRowKeyCompare::operator()(const ObRowkey *left, const ObRowkey *right) } else if (OB_UNLIKELY(NULL == left) || OB_UNLIKELY(NULL == right)) { result_code_ = common::OB_INVALID_ARGUMENT; - LOG_WARN_RET(result_code_, "Invaid argument, ", KP(left), KP(right), K_(result_code)); + LOG_WARN_RET(result_code_, "Invalid argument, ", KP(left), KP(right), K_(result_code)); } else { bool_ret = (*left) < (*right); } From 82ba229789c77ab0db72da6663b0689b552b3c67 Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Thu, 17 Mar 2022 16:21:24 +0800 Subject: [PATCH 08/10] correct spelling --- src/sql/das/ob_das_location_router.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sql/das/ob_das_location_router.cpp b/src/sql/das/ob_das_location_router.cpp index 5d164d845e..2ac3b6b64f 100755 --- a/src/sql/das/ob_das_location_router.cpp +++ b/src/sql/das/ob_das_location_router.cpp @@ -489,7 +489,7 @@ int ObDASTabletMapper::get_all_tablet_and_object_id(ObIArray &tablet if (OB_NOT_NULL(table_schema_)) { if (!table_schema_->is_partitioned_table()) { if (OB_FAIL(get_non_partition_tablet_id(tablet_ids, out_part_ids))) { - LOG_WARN("get non partitino tablet id failed", K(ret)); + LOG_WARN("get non partition tablet id failed", K(ret)); } } else if (PARTITION_LEVEL_ONE == table_schema_->get_part_level()) { if (OB_FAIL(get_all_tablet_and_object_id(PARTITION_LEVEL_ONE, OB_INVALID_ID, @@ -894,7 +894,7 @@ int ObDASLocationRouter::nonblock_get_candi_tablet_locations(const ObDASTableLoc candi_tablet_locs.reset(); int64_t N = tablet_ids.count(); if (OB_FAIL(candi_tablet_locs.prepare_allocate(N))) { - LOG_WARN("Partitoin location list prepare error", K(ret)); + LOG_WARN("Partition location list prepare error", K(ret)); } else { ObLSLocation location; int64_t i = 0; From efbd59683ae87c4b9b7912d3d0ca519c24fff1e1 Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Thu, 21 Apr 2022 16:21:24 +0800 Subject: [PATCH 09/10] correct spelling --- src/sql/das/ob_das_update_op.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/das/ob_das_update_op.cpp b/src/sql/das/ob_das_update_op.cpp index ec2742385d..aa19975ee8 100644 --- a/src/sql/das/ob_das_update_op.cpp +++ b/src/sql/das/ob_das_update_op.cpp @@ -212,7 +212,7 @@ int ObDASUpdIterator::get_next_spatial_index_row(ObNewRow *&row) } } else if (OB_ISNULL(spatial_rows)) { if (OB_FAIL(create_spatial_index_store())) { - LOG_WARN("create spatila index rows store failed", K(ret)); + LOG_WARN("create spatial index rows store failed", K(ret)); } else { spatial_rows = get_spatial_index_rows(); } From 53974f7cfc828f7842b135b02c3de7a50ddbb3cb Mon Sep 17 00:00:00 2001 From: luoshengchang Date: Fri, 29 Apr 2022 16:21:24 +0800 Subject: [PATCH 10/10] correct spelling --- src/sql/das/ob_das_utils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/das/ob_das_utils.cpp b/src/sql/das/ob_das_utils.cpp index 332dd9a481..37527f292a 100644 --- a/src/sql/das/ob_das_utils.cpp +++ b/src/sql/das/ob_das_utils.cpp @@ -343,7 +343,7 @@ int ObDASUtils::generate_spatial_index_rows( ret = OB_ALLOCATE_MEMORY_FAILED; LOG_WARN("failed to alloc memory for spatial index row mbr", K(ret)); } else if (OB_FAIL(spa_mbr.to_char(mbr, mbr_len))) { - LOG_WARN("failed transfrom ObSpatialMBR to string", K(ret)); + LOG_WARN("failed transform ObSpatialMBR to string", K(ret)); } else { for (uint64_t i = 0; OB_SUCC(ret) && i < cellids.size(); i++) { if (OB_ISNULL(obj_arr = reinterpret_cast(allocator.alloc(sizeof(ObObj) * rowkey_num)))) {