hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

modify codeowner

Browse Source
This commit is contained in:
obdev 2024-09-18 07:54:00 +00:00 committed by ob-robot
parent 6c1e485dfd
commit 17112490dd
15 changed files with 22 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/rootserver/ddl_task/ob_ddl_task.cpp
View File

@ -264,7 +264,7 @@ void ObDDLTracing::close()
{
if (OB_DDL_TASK_ENABLE_TRACING) {
int ret = OB_SUCCESS;
// TODO hanxuan fix MTL_SWITCH
// TODO jiahua.cjh fix MTL_SWITCH
MTL_SWITCH(OB_SYS_TENANT_ID) {
end_status_span();
// flush task span
@ -389,7 +389,7 @@ void ObDDLTracing::end_task_span()
FLT_RESTORE_DDL_TRACE_CTX(trace_ctx_);
FLT_SET_AUTO_FLUSH(true);
// task_->flt_set_task_span_tag();
// TODO hanxuan fix MTL_SWITCH
// TODO jiahua.cjh fix MTL_SWITCH
MTL_SWITCH(OB_SYS_TENANT_ID) {
FLT_END_SPAN(task_span_);
}
@ -554,7 +554,7 @@ void ObDDLTracing::end_status_span()
FLT_RESTORE_DDL_TRACE_CTX(trace_ctx_);
FLT_SET_AUTO_FLUSH(true);
//task_->flt_set_status_span_tag();
// TODO hanxuan fix MTL_SWITCH
// TODO jiahua.cjh fix MTL_SWITCH
MTL_SWITCH(OB_SYS_TENANT_ID) {
FLT_END_SPAN(status_span_);
}

4
src/rootserver/ddl_task/ob_fts_index_build_task.cpp
View File

@ -1418,7 +1418,7 @@ int ObFtsIndexBuildTask::submit_drop_fts_index_task()
}
if (OB_FAIL(ret)) {
} else if (OB_ISNULL(fts_index_aux_schema)) {
// TODO hanxuan fix create drop fts index when fts index schema is not generated
// TODO yunshan.tys fix create drop fts index when fts index schema is not generated
ret = OB_ERR_UNEXPECTED;
LOG_WARN("fts index aux schema is nullptr, fail to roll back", K(ret));
} else {
@ -1522,7 +1522,7 @@ int ObFtsIndexBuildTask::validate_checksum()
ret = OB_STATE_NOT_MATCH;
LOG_WARN("task status not match", K(ret), K(task_status_));
} else {
// TODO hanxuan validate checksum, set next status to FAIL if validation failed
// TODO yunshan.tys validate checksum, set next status to FAIL if validation failed
if (OB_SUCC(ret)) {
state_finished = true;
}

2
src/rootserver/ob_ddl_service.cpp
View File

@ -13567,7 +13567,7 @@ int ObDDLService::alter_table_in_trans(obrpc::ObAlterTableArg &alter_table_arg,
is_fts_index(create_index_arg->index_type_) ||
is_multivalue_index(create_index_arg->index_type_) ||
is_vec_index(create_index_arg->index_type_)) {
// TODO hanxuan tempory bypass sumbit build fulltext index task
// TODO yunshan.tys tempory bypass sumbit build fulltext index task
// TODO yunyi tempory bypass sumbit build multi value index task
} else {
ObArray<ObTabletID> inc_tablet_ids;

10
src/share/inner_table/ob_inner_table_schema_def.py
View File

@ -10536,7 +10536,7 @@ def_table_schema(
)
def_table_schema(
owner = 'luhaopeng.lhp',
owner = 'baichangmin.bcm',
table_name = '__all_virtual_table_mgr',
table_id = '12034',
table_type = 'VIRTUAL_TABLE',
@ -18766,7 +18766,7 @@ WHERE SVR_IP=HOST_IP() AND SVR_PORT=RPC_PORT()
)
def_table_schema(
owner = 'luhaopeng.lhp',
owner = 'baichangmin.bcm',
table_name = 'GV$OB_SSTABLES',
table_id = '21100',
table_type = 'SYSTEM_VIEW',
@ -18807,7 +18807,7 @@ FROM
)
def_table_schema(
owner = 'luhaopeng.lhp',
owner = 'baichangmin.bcm',
table_name = 'V$OB_SSTABLES',
table_id = '21101',
table_type = 'SYSTEM_VIEW',
@ -59496,7 +59496,7 @@ SVR_PORT
)
def_table_schema(
owner = 'luhaopeng.lhp',
owner = 'baichangmin.bcm',
table_name = 'GV$OB_SSTABLES',
name_postfix = '_ORA',
database_id = 'OB_ORA_SYS_DATABASE_ID',
@ -59536,7 +59536,7 @@ FROM
)
def_table_schema(
owner = 'luhaopeng.lhp',
owner = 'baichangmin.bcm',
table_name = 'V$OB_SSTABLES',
name_postfix = '_ORA',
database_id = 'OB_ORA_SYS_DATABASE_ID',

2
src/share/ob_fts_index_builder_util.cpp
View File

@ -195,7 +195,7 @@ int ObFtsIndexBuilderUtil::generate_fts_aux_index_name(
obrpc::ObCreateIndexArg &arg,
ObIAllocator *allocator)
{
// TODO: @zhenhan.gzh remove index name postfix, and only take one name in index namespace for fulltext index
// TODO: @yunshan.tys remove index name postfix, and only take one name in index namespace for fulltext index
int ret = OB_SUCCESS;
char *name_buf = nullptr;
share::schema::ObIndexType type = arg.index_type_;

2
src/sql/engine/cmd/ob_table_executor.cpp
View File

@ -925,7 +925,7 @@ int ObAlterTableExecutor::alter_table_rpc_v2(
} else if (INDEX_TYPE_PRIMARY == create_index_arg->index_type_ ||
is_fts_index(create_index_arg->index_type_) ||
is_multivalue_index(create_index_arg->index_type_)) {
// TODO hanxuan temporary bypass, since res.res_arg_array_ is empty
// TODO yunshan.tys temporary bypass, since res.res_arg_array_ is empty
// TODO yunyi temporary bypass, since res.res_arg_array_ is empty
} else if (!is_sync_ddl_user) {
// 只考虑非备份恢复时的索引同步检查

2
src/storage/access/ob_pushdown_aggregate.cpp
View File

@ -367,7 +367,7 @@ int ObAggCell::read_agg_datum(
skip_index_datum_.reuse();
skip_index_datum_.set_null();
blocksstable::ObSkipIndexColMeta meta;
// TODO: @luhaopeng.lhp fix col_index in cg, use 0 temporarily
// TODO: @baichangmin.bcm fix col_index in cg, use 0 temporarily
meta.col_idx_ = is_cg ? 0 : static_cast<uint32_t>(basic_info_.col_index_);
switch (agg_type_) {
case ObPDAggType::PD_SUM_OP_SIZE:

2
src/storage/access/ob_pushdown_aggregate_vec.cpp
View File

@ -366,7 +366,7 @@ int ObAggCellVec::read_agg_datum(
skip_index_datum_.reuse();
skip_index_datum_.set_null();
blocksstable::ObSkipIndexColMeta meta;
// TODO: @luhaopeng.lhp fix col_index in cg, use 0 temporarily
// TODO: @baichangmin.bcm fix col_index in cg, use 0 temporarily
meta.col_idx_ = col_index;
switch (agg_type_) {
case PD_COUNT: {

2
src/storage/blocksstable/index_block/ob_index_block_builder.cpp
View File

@ -2653,7 +2653,7 @@ int ObDataIndexBlockBuilder::init(
{
int ret = OB_SUCCESS;
void *buf = nullptr;
ObDataStoreDesc *tmp_data_store_desc = nullptr; // TODO:luhaopeng.lhp rm this
ObDataStoreDesc *tmp_data_store_desc = nullptr;
ObDataStoreDesc *index_store_desc = nullptr;
ObDataStoreDesc *container_store_desc = nullptr;
if (OB_UNLIKELY(is_inited_)) {

1
src/storage/blocksstable/ob_macro_block_bare_iterator.cpp
View File

@ -350,7 +350,6 @@ int ObMicroBlockBareIterator::get_next_micro_block_desc(
} else if (OB_FAIL(rowkey.deep_copy(micro_block_desc.last_rowkey_, allocator))) {
STORAGE_LOG(WARN, "Fail to deep copy last rowkey", K(ret));
} else if (need_check_sum) {
// TODO(luhaopeng.lhp): check it
ObMicroBlockChecksumHelper checksum_helper;
if (OB_FAIL(checksum_helper.init(&data_store_desc.get_col_desc_array(), data_store_desc.contain_full_col_descs()))) {
STORAGE_LOG(WARN, "Failed to init checksum helper", K(ret), K(data_store_desc));

2
src/storage/tablet/ob_tablet.cpp
View File

@ -7558,7 +7558,7 @@ int ObTablet::validate_medium_info_list(
const common::ObTabletID &tablet_id = tablet_meta_.tablet_id_;
const ObTabletDumpedMediumInfo *medium_info_list = mds_data.medium_info_list_.ptr_;
// const ObExtraMediumInfo &extra_info = mds_data.extra_medium_info_;
// TODO: @luhaopeng.lhp after mds_mvs joint debugging completed
// TODO: @baichangmin.bcm after mds_mvs joint debugging completed
const ObExtraMediumInfo &extra_info = tablet_meta_.extra_medium_info_;
if (mds_data.medium_info_list_.is_none_object()) {

2
src/storage/tablet/ob_tablet_create_mds_helper.cpp
View File

@ -647,7 +647,7 @@ int ObTabletCreateMdsHelper::check_and_get_create_tablet_schema_info(
micro_index_clustered = extra_info.micro_index_clustered_;
if (DATA_VERSION_4_3_0_0 <= extra_info.tenant_data_version_) {
need_create_empty_major_sstable = extra_info.need_create_empty_major_;
// TODO: @jinzhu, please remove me later, after hanxuan implement fts ddl task for post-creating index.
// TODO: @jinzhu, please remove me later, after implement fts ddl task for post-creating index.
if (create_tablet_schema->is_fts_index() && !create_tablet_schema->can_read_index()) {
need_create_empty_major_sstable = true;
}

2
src/storage/tablet/ob_tablet_create_sstable_param.cpp
View File

@ -752,7 +752,7 @@ int ObTabletCreateSSTableParam::init_for_mds(
const blocksstable::ObSSTableMergeRes &res,
const ObStorageSchema &mds_schema)
{
// TODO: @luhaopeng.lhp check ctx valid for mds
// TODO: @baichangmin.bcm check ctx valid for mds
// reference to merge info
int ret = OB_SUCCESS;
const compaction::ObStaticMergeParam &static_param = ctx.static_param_;

4
src/storage/tablet/ob_tablet_persister.cpp
View File

@ -622,7 +622,7 @@ int ObTabletPersister::convert_tablet_to_disk_arg(
LOG_WARN("fail to copy tablet meta", K(ret), K(tablet));
} else if (FALSE_IT(arg.rowkey_read_info_ptr_ = tablet.rowkey_read_info_)) {
// } else if (FALSE_IT(arg.extra_medium_info_ = tablet.mds_data_.extra_medium_info_)) {
// TODO: @luhaopeng.lhp after mds_mvs joint debugging completed
// TODO: @baichangmin.bcm after mds_mvs joint debugging completed
} else if (OB_FAIL(fetch_table_store_and_write_info(tablet, table_store_wrapper,
write_infos, total_write_ctxs, total_tablet_meta_size, block_info_set))) {
LOG_WARN("fail to fetch table store and write info", K(ret));
@ -1014,7 +1014,7 @@ int ObTabletPersister::convert_arg_to_tablet(const ObTabletTransformArg &arg, Ob
LOG_WARN("invalid arguments", K(ret), K(arg));
} else if (OB_FAIL(tablet.tablet_meta_.assign(arg.tablet_meta_))) {
LOG_WARN("fail to copy tablet meta", K(ret), K(arg.tablet_meta_));
// TODO: @luhaopeng.lhp after mds_mvs joint debugging completed, delete mds_data_.tablet_status_cache_
// TODO: @baichangmin.bcm after mds_mvs joint debugging completed, delete mds_data_.tablet_status_cache_
} else if (OB_FAIL(tablet.assign_memtables(arg.memtables_, arg.memtable_count_))) {
LOG_WARN("fail to assign memtables", K(ret), KP(arg.memtables_), K(arg.memtable_count_));
} else {

2
unittest/storage/multi_data_source/test_mds_dump_kv.cpp
View File

@ -265,7 +265,7 @@ void TestMdsDumpKV::test_dump_kv_wrapper()
ASSERT_EQ(OB_SUCCESS, mds_row.init(ObMdsSchemaHelper::MDS_MULTI_VERSION_ROW_COLUMN_CNT));
ASSERT_EQ(OB_SUCCESS, adapter.convert_to_mds_row(allocator, mds_row));
// TODO(@luhaopeng.lhp): open this case later
// TODO(@baichangmin.bcm): open this case later
/*
// convert adapter from row;
MdsDumpKVStorageAdapter adapter2;