hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix enumset cast to time in static typing engine

Browse Source
This commit is contained in:
br0
2021-09-22 20:10:47 +08:00
committed by wangzelin.wzl
parent b2e66c1cd8
commit 1765522f95
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/sql/engine/expr/ob_expr_cast.cpp
View File

@ -368,7 +368,19 @@ int ObExprCast::calc_result_type2(
OZ(ObRawExprUtils::setup_extra_cast_utf8_type(dst_type, dst_type_utf8));
OX(type1.set_calc_meta(dst_type_utf8.get_obj_meta()));
} else {
type1.set_calc_meta(type1.get_obj_meta());
bool need_warp = false;
if (ob_is_enumset_tc(type1.get_type())) {
// For enum/set type, need to check whether warp to string is required.
if (OB_FAIL(ObRawExprUtils::need_wrap_to_string(type1.get_type(), type1.get_calc_type(), false, need_warp))) {
LOG_WARN("need_wrap_to_string failed", K(ret), K(type1));
}
} else if (OB_LIKELY(need_warp)) {
// need_warp is true, no-op and keep type1's calc_type is dst_type. It will be wrapped
// to string in ObRawExprWrapEnumSet::visit(ObSysFunRawExpr &expr) later.
} else {
// need_warp is false, set calc_type to type1 itself.
type1.set_calc_meta(type1.get_obj_meta());
}
}
} else {
// no need to set cast mode, already setup while deduce type.

1
src/sql/resolver/expr/ob_raw_expr_wrap_enum_set.cpp
View File

@ -721,6 +721,7 @@ int ObRawExprWrapEnumSet::visit(ObSysFunRawExpr& expr)
} else if (ob_is_enumset_tc(param_expr->get_data_type())) {
ObObjType calc_type = expr.get_input_types().at(i).get_calc_type();
ObSysFunRawExpr* wrapped_expr = NULL;
// Enumset warp to string in CAST expr will be handled here.
if (OB_FAIL(wrap_type_to_str_if_necessary(
param_expr, calc_type, get_current_level(), is_same_need, wrapped_expr))) {
LOG_WARN("failed to wrap_type_to_str_if_necessary", K(i), K(expr), K(ret));