hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix copy shared exec param bug

Browse Source
This commit is contained in:
jinmaoli
2023-11-30 09:16:16 +00:00
committed by ob-robot
parent 94ccfbdb56
commit 19a1c56239
3 changed files with 37 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/sql/resolver/expr/ob_raw_expr_copier.cpp
View File

@ -61,6 +61,14 @@ int ObPLExprCopier::check_need_copy(const ObRawExpr *old_expr,
return OB_SUCCESS;
}
int ObPLExprCopier::find_in_copy_context(const ObRawExpr *old_expr,
ObRawExpr *&new_expr)
{
UNUSED(old_expr);
new_expr = NULL;
return OB_SUCCESS;
}
int ObPLExprCopier::do_copy_expr(const ObRawExpr *old_expr,
ObRawExpr *&new_expr)
{
@ -86,6 +94,23 @@ int ObPLExprCopier::do_copy_expr(const ObRawExpr *old_expr,
int ObRawExprCopier::check_need_copy(const ObRawExpr *old_expr,
ObRawExpr *&new_expr)
{
int ret = OB_SUCCESS;
new_expr = NULL;
if (OB_FAIL(find_in_copy_context(old_expr, new_expr))) {
LOG_WARN("faild to find in copy context", K(ret));
} else if (OB_ISNULL(new_expr) &&
old_expr->is_exec_param_expr() &&
!static_cast<const ObExecParamRawExpr *>(old_expr)->is_onetime()) {
// TODO link.zt skip the copy of exec param expr
// let the query ref raw expr to copy the expr
// to be improved
new_expr = const_cast<ObRawExpr *>(old_expr);
}
return ret;
}
int ObRawExprCopier::find_in_copy_context(const ObRawExpr *old_expr, ObRawExpr *&new_expr)
{
int ret = OB_SUCCESS;
int tmp = OB_SUCCESS;
@ -106,14 +131,6 @@ int ObRawExprCopier::check_need_copy(const ObRawExpr *old_expr,
ret = tmp;
LOG_WARN("get expr from hash map failed", K(ret));
}
if (OB_SUCC(ret) && OB_ISNULL(new_expr) &&
old_expr->is_exec_param_expr() &&
!static_cast<const ObExecParamRawExpr *>(old_expr)->is_onetime()) {
// TODO link.zt skip the copy of exec param expr
// let the query ref raw expr to copy the expr
// to be improved
new_expr = const_cast<ObRawExpr *>(old_expr);
}
return ret;
}