hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix base64 bug: ob doesn't return null as expected

Browse Source
This commit is contained in:
obdev
2023-01-04 11:38:19 +00:00
committed by ob-robot
parent a2c0577954
commit 1c9259243e
3 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/engine/expr/ob_expr_from_base64.cpp
View File

@ -179,7 +179,9 @@ int ObExprFromBase64::eval_from_base64_batch(const ObExpr &expr, ObEvalCtx &ctx,
const ObString & in_raw = arg->get_string(); const ObString & in_raw = arg->get_string();
ObLength in_raw_len = in_raw.length(); ObLength in_raw_len = in_raw.length();
const char *buf = in_raw.ptr(); const char *buf = in_raw.ptr();
if (NULL == buf) { if (arg->is_null()) {
res[j].set_null();
} else if (NULL == buf) {
res[j].set_string(nullptr, 0); res[j].set_string(nullptr, 0);
} else { } else {
char *output_buf = nullptr; char *output_buf = nullptr;

6
src/sql/engine/expr/ob_expr_to_base64.cpp
View File

@ -172,8 +172,10 @@ int ObExprToBase64::eval_to_base64_batch(const ObExpr &expr,
ObLength in_raw_len = in_raw.length(); ObLength in_raw_len = in_raw.length();
const char *buf = in_raw.ptr(); const char *buf = in_raw.ptr();
char *output_buf = nullptr; char *output_buf = nullptr;
int64_t buf_len = base64_needed_encoded_length(in_raw_len); int64_t buf_len = 0;
if (OB_UNLIKELY(buf_len == 0)) { if (arg->is_null()) {
res[j].set_null();
} else if (OB_UNLIKELY((buf_len = base64_needed_encoded_length(in_raw_len)) == 0)) {
res[j].set_string(nullptr, 0); res[j].set_string(nullptr, 0);
} else { } else {
int64_t pos = 0; int64_t pos = 0;