hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix bug when duplicated_rows is push_back to duplicated_iter_list_ and fails, the memory of duplicated_rows may be leaked.

Browse Source
This commit is contained in:
yishenglanlingzui
2024-04-01 02:56:24 +00:00
committed by ob-robot
parent c71c2e4d11
commit 1da0980936
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/das/ob_das_insert_op.cpp
View File

@ -200,6 +200,10 @@ int ObDASInsertOp::insert_row_with_fetch()
}
}
}
if (OB_FAIL(ret) && OB_NOT_NULL(duplicated_rows)) {
ObQueryIteratorFactory::free_insert_dup_iter(duplicated_rows);
duplicated_rows = NULL;
}
}
ret = OB_ITER_END == ret ? OB_SUCCESS : ret;
for (int64_t i = 0; OB_SUCC(ret) && i < related_ctdefs_.count(); ++i) {
@ -258,9 +262,14 @@ int ObDASInsertOp::insert_row_with_fetch()
} else {
// 需要释放iter的内存， 否则会内存泄漏
ObQueryIteratorFactory::free_insert_dup_iter(duplicated_rows);
duplicated_rows = NULL;
}
}
}
if (OB_FAIL(ret) && OB_NOT_NULL(duplicated_rows)) {
ObQueryIteratorFactory::free_insert_dup_iter(duplicated_rows);
duplicated_rows = NULL;
}
}
ret = OB_ITER_END == ret ? OB_SUCCESS : ret;
}