From 1f1001b640863701b1375fb1dac45ba7ce189e0e Mon Sep 17 00:00:00 2001 From: xianyu-w <707512433@qq.com> Date: Mon, 20 Mar 2023 20:40:30 +0800 Subject: [PATCH] Revert print cast for questionmark in dblink --- src/sql/resolver/expr/ob_raw_expr_printer.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/sql/resolver/expr/ob_raw_expr_printer.cpp b/src/sql/resolver/expr/ob_raw_expr_printer.cpp index 83541cd828..fab268be71 100644 --- a/src/sql/resolver/expr/ob_raw_expr_printer.cpp +++ b/src/sql/resolver/expr/ob_raw_expr_printer.cpp @@ -207,7 +207,6 @@ int ObRawExprPrinter::print(ObConstRawExpr *expr) } else if (print_params_.for_dblink_ && T_QUESTIONMARK == expr->get_expr_type()) { int64_t idx = expr->get_value().get_unknown(); bool is_bool_expr = false; - bool is_null_type = ob_is_null(expr->get_result_type().get_type()); if (expr->is_exec_param_expr()) { ObExecParamRawExpr *exec_expr = static_cast(expr); if (OB_FAIL(ObRawExprUtils::check_is_bool_expr(exec_expr->get_ref_expr(), is_bool_expr))) { @@ -227,18 +226,11 @@ int ObRawExprPrinter::print(ObConstRawExpr *expr) * */ LOG_WARN("fail to print 1 =", K(ret)); - } else if (!is_null_type && OB_FAIL(databuff_printf(buf_, buf_len_, *pos_, "cast("))) { - LOG_WARN("fail to print cast(", K(ret)); } else if (OB_NOT_NULL(param_store_) && 0 <= idx && idx < param_store_->count()) { OZ (param_store_->at(idx).print_sql_literal(buf_, buf_len_, *pos_, print_params_)); } else if (OB_FAIL(ObLinkStmtParam::write(buf_, buf_len_, *pos_, expr->get_value().get_unknown()))) { LOG_WARN("fail to write param to buf", K(ret)); } - if (OB_SUCC(ret) && !is_null_type) { - DATA_PRINTF(" as "); - OZ(print_type(expr->get_result_type())); - DATA_PRINTF(")"); - } } else if (OB_NOT_NULL(param_store_) && T_QUESTIONMARK == expr->get_expr_type()) { int64_t idx = expr->get_value().get_unknown(); CK (0 <= idx && idx < param_store_->count());