hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix memory leak cuased by ObTmpMultiPageIOCallback array assign failed

Browse Source
This commit is contained in:
obdev
2024-03-18 06:21:12 +00:00
committed by ob-robot
parent 7d023cf96b
commit 1f434bc5e8
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/storage/blocksstable/ob_tmp_file_cache.cpp
View File

@ -229,12 +229,15 @@ int ObTmpPageCache::prefetch(
callback->allocator_ = &allocator; callback->allocator_ = &allocator;
if (OB_FAIL(callback->page_io_infos_.assign(page_io_infos))) { if (OB_FAIL(callback->page_io_infos_.assign(page_io_infos))) {
STORAGE_LOG(WARN, "fail to assign page io infos", K(ret), K(page_io_infos.count()), K(info)); STORAGE_LOG(WARN, "fail to assign page io infos", K(ret), K(page_io_infos.count()), K(info));
if (OB_NOT_NULL(callback)) { // handle ObArray assign fail case and free callback
callback->~ObTmpMultiPageIOCallback();
allocator.free(callback);
callback = nullptr;
}
} else if (OB_FAIL(inner_read_io(info, callback, mb_handle))) { } else if (OB_FAIL(inner_read_io(info, callback, mb_handle))) {
STORAGE_LOG(WARN, "fail to inner read io", K(ret), K(mb_handle)); STORAGE_LOG(WARN, "fail to inner read io", K(ret), K(mb_handle));
} }
// There is no need to handle error cases (freeing the memory of the // inner_read_io will handle error cases and free the memory of callback.
// callback) because inner_read_io will handle error cases and free the
// memory of the callback.
} }
} }
return ret; return ret;