hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Updating max_commit_ts from ls to tenant level

Browse Source
This commit is contained in:
obdev
2023-03-21 15:12:03 +00:00
committed by ob-robot
parent 74a5f5ea3f
commit 276a09d8f4
2 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/storage/tx/ob_tx_loop_worker.cpp
View File

@ -111,6 +111,12 @@ void ObTxLoopWorker::run1()
(void)scan_all_ls_(can_gc_tx, can_gc_retain_ctx); (void)scan_all_ls_(can_gc_tx, can_gc_retain_ctx);
// TODO shanyan.g
// 1) We use max(max_commit_ts, gts_cache) as read snapshot,
// but now we adopt updating max_commit_ts periodly to avoid getting gts cache cost
// 2) Some time later, we will revert current modification when performance problem solved;
update_max_commit_ts_();
time_used = ObTimeUtility::current_time() - start_time_us; time_used = ObTimeUtility::current_time() - start_time_us;
if (time_used < LOOP_INTERVAL) { if (time_used < LOOP_INTERVAL) {
@ -186,12 +192,6 @@ int ObTxLoopWorker::scan_all_ls_(bool can_tx_gc, bool can_gc_retain_ctx)
// keep alive, interval = 100ms // keep alive, interval = 100ms
do_keep_alive_(cur_ls_ptr, min_start_scn, status); do_keep_alive_(cur_ls_ptr, min_start_scn, status);
// TODO shanyan.g
// 1) We use max(max_commit_ts, gts_cache) as read snapshot,
// but now we adopt updating max_commit_ts periodly to avoid getting gts cache cost
// 2) Some time later, we will revert current modification when performance problem solved;
update_max_commit_ts_(cur_ls_ptr);
if (can_gc_retain_ctx) { if (can_gc_retain_ctx) {
do_retain_ctx_gc_(cur_ls_ptr); do_retain_ctx_gc_(cur_ls_ptr);
} }
@ -229,11 +229,12 @@ void ObTxLoopWorker::do_tx_gc_(ObLS *ls_ptr, SCN &min_start_scn, MinStartScnStat
UNUSED(ret); UNUSED(ret);
} }
void ObTxLoopWorker::update_max_commit_ts_(ObLS *ls_ptr) void ObTxLoopWorker::update_max_commit_ts_()
{ {
int ret = OB_SUCCESS; int ret = OB_SUCCESS;
SCN snapshot; SCN snapshot;
const int64_t expire_ts = ObClockGenerator::getClock() + 1000000; // 1s const int64_t expire_ts = ObClockGenerator::getClock() + 1000000; // 1s
ObTransService *txs = NULL;
do { do {
int64_t n = ObClockGenerator::getClock(); int64_t n = ObClockGenerator::getClock();
@ -248,11 +249,11 @@ void ObTxLoopWorker::update_max_commit_ts_(ObLS *ls_ptr)
} else if (OB_UNLIKELY(!snapshot.is_valid())) { } else if (OB_UNLIKELY(!snapshot.is_valid())) {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
TRANS_LOG(WARN, "invalid snapshot from gts", K(snapshot)); TRANS_LOG(WARN, "invalid snapshot from gts", K(snapshot));
} else if (OB_ISNULL(txs = MTL(ObTransService *))) {
ret = OB_ERR_UNEXPECTED;
TRANS_LOG(ERROR, "unexpected transaction service", K(ret), KP(txs));
} else { } else {
if (NULL != ls_ptr) { txs->get_tx_version_mgr().update_max_commit_ts(snapshot, false);
ls_ptr->get_tx_svr()->get_trans_service()
->get_tx_version_mgr().update_max_commit_ts(snapshot, false);
}
} }
} while (OB_EAGAIN == ret); } while (OB_EAGAIN == ret);
} }

2
src/storage/tx/ob_tx_loop_worker.h
View File

@ -58,7 +58,7 @@ private:
int scan_all_ls_(bool can_tx_gc, bool can_gc_retain_ctx); int scan_all_ls_(bool can_tx_gc, bool can_gc_retain_ctx);
void do_keep_alive_(ObLS *ls, const share::SCN &min_start_scn, MinStartScnStatus status); // 100ms void do_keep_alive_(ObLS *ls, const share::SCN &min_start_scn, MinStartScnStatus status); // 100ms
void do_tx_gc_(ObLS *ls, share::SCN &min_start_scn, MinStartScnStatus &status); // 15s void do_tx_gc_(ObLS *ls, share::SCN &min_start_scn, MinStartScnStatus &status); // 15s
void update_max_commit_ts_(ObLS *ls); void update_max_commit_ts_();
void do_retain_ctx_gc_(ObLS * ls); // 15s void do_retain_ctx_gc_(ObLS * ls); // 15s
private: private: