hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix misuse op_alloc of TableNode in ObAutoincrementService::get_table_node (#388)

Browse Source
This commit is contained in:
Laughing
2021-10-14 15:40:15 +08:00
committed by GitHub
parent a600c3b82c
commit 28e32c861b
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/share/ob_autoincrement_service.cpp
View File

@ -634,8 +634,7 @@ int ObAutoincrementService::get_table_node(const AutoincParam& param, TableNode*
LOG_WARN("failed to get lock", K(ret)); LOG_WARN("failed to get lock", K(ret));
} else if (OB_ENTRY_NOT_EXIST == (ret = node_map_.get(key, table_node))) { } else if (OB_ENTRY_NOT_EXIST == (ret = node_map_.get(key, table_node))) {
LOG_INFO("alloc table node for auto increment key", K(key)); LOG_INFO("alloc table node for auto increment key", K(key));
if (NULL == (table_node = op_alloc(TableNode))) { if (OB_FAIL(node_map_.alloc_value(table_node))) {
ret = OB_ALLOCATE_MEMORY_FAILED;
LOG_ERROR("failed to alloc table node", K(param), K(ret)); LOG_ERROR("failed to alloc table node", K(param), K(ret));
} else if (OB_FAIL(table_node->init(param.autoinc_table_part_num_))) { } else if (OB_FAIL(table_node->init(param.autoinc_table_part_num_))) {
LOG_ERROR("failed to init table node", K(param), K(ret)); LOG_ERROR("failed to init table node", K(param), K(ret));
@ -649,7 +648,7 @@ int ObAutoincrementService::get_table_node(const AutoincParam& param, TableNode*
} }
} }
if (OB_FAIL(ret) && table_node != nullptr) { if (OB_FAIL(ret) && table_node != nullptr) {
op_free(table_node); node_map_.free_value(table_node);
table_node = NULL; table_node = NULL;
} }
} }