hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] [bugfix]:update duplicated columns should raise error 957.

Browse Source
This commit is contained in:
Monk-Liu
2022-11-24 10:10:17 +00:00
committed by wangzelin.wzl
parent 0fb66ff79b
commit 2a7e2e5eff
2 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/sql/resolver/dml/ob_update_resolver.cpp
View File

@ -212,6 +212,41 @@ int ObUpdateResolver::try_expand_returning_exprs()
} }
} }
} }
if (OB_SUCC(ret) && is_oracle_mode()) {
if (OB_FAIL(check_update_assign_duplicated(update_stmt))) {
LOG_WARN("update has duplicate columns", K(ret));
}
}
return ret;
}
int ObUpdateResolver::check_update_assign_duplicated(const ObUpdateStmt *update_stmt)
{
int ret = OB_SUCCESS;
if (OB_ISNULL(update_stmt)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("stmt is null", K(ret));
} else {
// check duplicate assignments
// update t1 set c1 = 1, c1 = 2;
const ObIArray<ObUpdateTableInfo*> &table_infos = update_stmt->get_update_table_info();
for (int64_t i = 0; OB_SUCC(ret) && i < table_infos.count(); ++i) {
ObUpdateTableInfo* table_info = table_infos.at(i);
if (OB_ISNULL(table_info)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("get null table info", K(ret));
}
for (int64_t j = 0; OB_SUCC(ret) && j < table_info->assignments_.count(); ++j) {
const ObAssignment &assign_item = table_info->assignments_.at(j);
if (assign_item.is_duplicated_) {
ret = OB_ERR_FIELD_SPECIFIED_TWICE;
LOG_USER_ERROR(OB_ERR_FIELD_SPECIFIED_TWICE, to_cstring(assign_item.column_expr_->get_column_name()));
}
}
}
}
return ret; return ret;
} }

1
src/sql/resolver/dml/ob_update_resolver.h
View File

@ -46,6 +46,7 @@ private:
int check_multi_update_table_conflict(); int check_multi_update_table_conflict();
int check_join_update_conflict(); int check_join_update_conflict();
int is_join_table_update(const ObDMLStmt *stmt, bool &is_multi_table); int is_join_table_update(const ObDMLStmt *stmt, bool &is_multi_table);
int check_update_assign_duplicated(const ObUpdateStmt *update_stmt);
int check_view_updatable(); int check_view_updatable();
int try_expand_returning_exprs(); int try_expand_returning_exprs();
int try_add_remove_const_expr_for_assignments(); int try_add_remove_const_expr_for_assignments();