hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove Defense

Browse Source
This commit is contained in:
obdev 2024-09-18 08:38:30 +00:00 committed by ob-robot
parent 1cd91e4ffa
commit 2efc3d2e63
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mittest/mtlenv/storage/test_tablet_status_cache.cpp
View File

@ -241,7 +241,6 @@ TEST_F(TestTabletStatusCache, get_transfer_out_tablet)
ret = ObTabletCreateDeleteHelper::check_and_get_tablet(key, tablet_handle, 1_s,
ObMDSGetTabletMode::READ_READABLE_COMMITED, ObTransVersion::MAX_TRANS_VERSION/*snapshot*/);
//ASSERT_EQ(OB_SCHEMA_EAGAIN, ret);
ASSERT_EQ(OB_ERR_UNEXPECTED, ret); // not committed but user_data.transfer_scn_ has valid_value
ASSERT_TRUE(!tablet->tablet_status_cache_.is_valid());
// mode is READ_ALL_COMMITED, allow to get TRANSFER_OUT status tablet

3
src/storage/tablet/ob_tablet_create_delete_helper.cpp
View File

@ -427,9 +427,6 @@ int ObTabletCreateDeleteHelper::check_read_snapshot_for_transfer_out(
LOG_WARN("invalid args", K(ret), K(ls_id), K(tablet_id), K(user_data));
} else if (OB_FAIL(read_snapshot.convert_for_tx(snapshot_version))) {
LOG_WARN("failed to convert from int64_t to SCN", K(ret), K(snapshot_version));
} else if (!is_committed && !transfer_scn.is_min()) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("if not committed, transfer_scn should not has value", KR(ret), K(is_committed), K(transfer_scn), K(tablet));
} else if (transfer_scn.is_min()) {
// noop, before on_redo()
} else if (read_snapshot >= transfer_scn) {