hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

check type of raw expr before static_cast

Browse Source
This commit is contained in:
sdc
2023-05-31 18:42:07 +00:00
committed by ob-robot
parent 135eb7bbc3
commit 32b88df229
3 changed files with 37 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/engine/expr/ob_expr_is.cpp
View File

@ -167,6 +167,7 @@ int ObExprIsBase::cg_expr_internal(ObExprCGCtx &op_cg_ctx, const ObRawExpr &raw_
UNUSED(op_cg_ctx);
int ret = OB_SUCCESS;
const ObOpRawExpr *op_raw_expr = static_cast<const ObOpRawExpr*>(&raw_expr);
const ObRawExpr *child = NULL;
if (rt_expr.arg_cnt_ != 2) {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("isnot expr should have 2 params", K(ret), K(rt_expr.arg_cnt_));
@ -174,9 +175,12 @@ int ObExprIsBase::cg_expr_internal(ObExprCGCtx &op_cg_ctx, const ObRawExpr &raw_
|| OB_ISNULL(rt_expr.args_[1])) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("children of isnot expr is null", K(ret), K(rt_expr.args_));
} else if (OB_ISNULL(child = op_raw_expr->get_param_expr(1))
|| OB_UNLIKELY(!child->is_const_raw_expr())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("child is null", K(ret), KPC(child));
} else {
const ObRawExpr *param2 = op_raw_expr->get_param_expr(1);
const_param2 = static_cast<const ObConstRawExpr *>(param2);
const_param2 = static_cast<const ObConstRawExpr *>(child);
}
return ret;
}