hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Unpivot op not skip child row in vectorized scenarios

Browse Source
This commit is contained in:
obdev
2023-06-27 10:12:28 +00:00
committed by ob-robot
parent 28506560f5
commit 37489786d0
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/sql/engine/subquery/ob_unpivot_op.cpp
View File

@ -192,6 +192,12 @@ int ObUnpivotOp::inner_get_next_batch(const int64_t max_row_cnt)
for (int64_t read_piece = 0; OB_SUCC(ret) && read_piece < brs_.size_; ++read_piece) { for (int64_t read_piece = 0; OB_SUCC(ret) && read_piece < brs_.size_; ++read_piece) {
int64_t read_cur_row = (curr_part_idx_ * brs_.size_ + read_piece) / MY_SPEC.max_part_count_; int64_t read_cur_row = (curr_part_idx_ * brs_.size_ + read_piece) / MY_SPEC.max_part_count_;
// check row whether is skip in child
if (OB_SUCC(ret) && child_brs_->skip_->at(read_cur_row)) {
brs_.skip_->set(read_piece);
curr_cols_idx_ = (curr_cols_idx_ + 1) % MY_SPEC.max_part_count_;
continue;
}
// check for_column whether is all null // check for_column whether is all null
if (OB_SUCC(ret) && !MY_SPEC.unpivot_info_.is_include_null_) { if (OB_SUCC(ret) && !MY_SPEC.unpivot_info_.is_include_null_) {
int64_t null_count = 0; int64_t null_count = 0;
@ -218,23 +224,21 @@ int ObUnpivotOp::inner_get_next_batch(const int64_t max_row_cnt)
continue; continue;
} }
} }
// old_column
int64_t output_idx = 0; int64_t output_idx = 0;
// old_column
for (; OB_SUCC(ret) && output_idx < MY_SPEC.unpivot_info_.old_column_count_; ++output_idx) { for (; OB_SUCC(ret) && output_idx < MY_SPEC.unpivot_info_.old_column_count_; ++output_idx) {
ObExpr *father_expr = MY_SPEC.output_[output_idx]; ObExpr *father_expr = MY_SPEC.output_[output_idx];
ObDatum *father_datum = father_expr->locate_batch_datums(eval_ctx_); ObDatum *father_datum = father_expr->locate_batch_datums(eval_ctx_);
father_datum[read_piece] = multiplex_[output_idx * brs_.size_ + read_cur_row]; int64_t datum_pos = father_expr->is_batch_result() ? read_piece : 0;
father_datum[datum_pos] = multiplex_[output_idx * brs_.size_ + read_cur_row];
} }
// new_column // new_column
if (0 == curr_cols_idx_) { if (0 == curr_cols_idx_) {
for (; OB_SUCC(ret) && output_idx < MY_SPEC.get_output_count(); ++output_idx) { for (; OB_SUCC(ret) && output_idx < MY_SPEC.get_output_count(); ++output_idx) {
ObExpr *father_expr = MY_SPEC.output_[output_idx]; ObExpr *father_expr = MY_SPEC.output_[output_idx];
ObDatum *father_datum = father_expr->locate_batch_datums(eval_ctx_); ObDatum *father_datum = father_expr->locate_batch_datums(eval_ctx_);
if (father_expr->is_batch_result()) { int64_t datum_pos = father_expr->is_batch_result() ? read_piece : 0;
father_datum[read_piece] = multiplex_[output_idx * brs_.size_ + read_cur_row]; father_datum[datum_pos] = multiplex_[output_idx * brs_.size_ + read_cur_row];
} else {
father_datum[0] = multiplex_[output_idx * brs_.size_ + read_cur_row];
}
} }
} else { } else {
const int64_t base_idx = curr_cols_idx_ * MY_SPEC.unpivot_info_.get_new_column_count(); const int64_t base_idx = curr_cols_idx_ * MY_SPEC.unpivot_info_.get_new_column_count();
@ -244,13 +248,11 @@ int ObUnpivotOp::inner_get_next_batch(const int64_t max_row_cnt)
ObExpr *father_expr = MY_SPEC.output_[output_idx]; ObExpr *father_expr = MY_SPEC.output_[output_idx];
ObDatum *child_datum = child_expr->locate_batch_datums(eval_ctx_); ObDatum *child_datum = child_expr->locate_batch_datums(eval_ctx_);
ObDatum *father_datum = father_expr->locate_batch_datums(eval_ctx_); ObDatum *father_datum = father_expr->locate_batch_datums(eval_ctx_);
if (OB_UNLIKELY(!father_expr->is_batch_result())) { int64_t datum_pos = father_expr->is_batch_result() ? read_piece : 0;
ret = OB_ERR_UNEXPECTED; if (child_expr->is_batch_result()) {
LOG_WARN("output of unpivot should be batch result", K(ret), KPC(father_expr)); father_datum[datum_pos] = child_datum[read_cur_row];
} else if (child_expr->is_batch_result()) {
father_datum[read_piece] = child_datum[read_cur_row];
} else { } else {
father_datum[read_piece] = *child_datum; father_datum[datum_pos] = *child_datum;
} }
} }
} }