hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[BUG] remove unexpected error msg

Browse Source
This commit is contained in:
Handora
2023-03-02 15:33:37 +00:00
committed by ob-robot
parent 6979025cf4
commit 37fc47ee82
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/storage/concurrency_control/ob_multi_version_garbage_collector.cpp
View File

@ -1180,16 +1180,11 @@ int ObMultiVersionGCSnapshotCalculator::operator()(const share::SCN snapshot_ver
current_ts - create_time > 2 * ObMultiVersionGarbageCollector::GARBAGE_COLLECT_RECLAIM_DURATION &&
// for mock or test that change GARBAGE_COLLECT_EXEC_INTERVAL to a small value
current_ts - create_time > 2 * 3 * 10_min) {
if (REACH_COUNT_INTERVAL(10L)) {
// we report error here for long time warning
MVCC_LOG(ERROR, "ignore too old version too long", K(snapshot_version),
K(snapshot_type), K(current_ts), K(create_time), K(addr));
} else {
// we report WARN here because there may be servers offline and online
// suddenly and report a stale txn
MVCC_LOG(WARN, "ignore too old version", K(snapshot_version),
K(snapshot_type), K(current_ts), K(create_time), K(addr));
}
// we report WARN here because there may be servers offline and online
// suddenly and report a stale txn or there may be tenant being dropped
// and alived server may fetch the tenant info
MVCC_LOG(WARN, "ignore too old version", K(snapshot_version),
K(snapshot_type), K(current_ts), K(create_time), K(addr));
} else {
reserved_snapshot_version_ = snapshot_version;
reserved_snapshot_type_ = snapshot_type;
@ -1342,7 +1337,17 @@ bool GetMinActiveSnapshotVersionFunctor::operator()(sql::ObSQLSessionMgr::Key ke
}
}
if (OB_SUCC(ret) && snapshot_version < min_active_snapshot_version_) {
if (OB_SUCC(ret)
&& share::SCN::min_scn() != snapshot_version
&& snapshot_version < min_active_snapshot_version_) {
const int64_t current_timestamp = ObClockGenerator::getRealClock();
const int64_t snapshot_version_ts = snapshot_version.get_val_for_tx() / 1000;
if (snapshot_version_ts < current_timestamp
&& current_timestamp - snapshot_version_ts > 100 * 1_min) {
MVCC_LOG(INFO, "GetMinActiveSnapshotVersionFunctor find a small snapshot txn",
K(MTL_ID()), KPC(sess_info), K(snapshot_version),
K(current_timestamp), K(min_active_snapshot_version_));
}
min_active_snapshot_version_ = snapshot_version;
}
}