hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] [to #52806614] fix anonymous block with out parameter on prexecute & ps protocol mixed running

Browse Source
This commit is contained in:
obdev
2024-07-16 04:48:55 +00:00
committed by ob-robot
parent f2f0402400
commit 3adb4c0c2e
6 changed files with 53 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/sql/ob_sql.cpp
View File

@ -1268,17 +1268,39 @@ int ObSql::do_real_prepare(const ObString &sql,
param_cnt = parse_result.question_mark_ctx_.count_;
info_ctx.normalized_sql_ = sql;
if (stmt::T_ANONYMOUS_BLOCK == stmt_type
&& context.is_prepare_protocol_
&& context.is_prepare_stage_
&& context.is_pre_execute_) {
&& context.is_prepare_protocol_
&& context.is_prepare_stage_
&& context.is_pre_execute_) {
OZ (result.reserve_param_columns(param_cnt));
for (int64_t i = 0; OB_SUCC(ret) && i < param_cnt; ++i) {
ObField param_field;
param_field.type_.set_type(ObIntType);
param_field.cname_ = ObString::make_string("?");
// 1. why mark 'SP_PARAM_INOUT' here ?
// if this prepare result reused by ps protocol. (here is prexecute protocol prepare)
// ps protocol will use this result to charge `Is this anonymous block has out row or not?`
// and if anonymous block has not out row, anonymous block can use AsyncCmdPlanDriver.
// but for now, anonymous block do not resolve, we can not know about out row infos.
// so we treat all parameter as inout paramter.
//
// 2. why inout parameter is ok ?
// actully when anonymous block execute, it will do real resolve again,
// and will fill out row infos again, we only use prepare inout infos to avoid to use AsyncCmdPlanDriver,
// because AsyncCmdPlanDriver nerver response result row.
//
// 3. what if new ps prepare reuse prexecute prepare result?
// it is not possible, because, we mark prexecute flag to PsStmtInfo,
// when ps prepare match PsStmtInfo, will check prexecute flag, if flag is true, will evcit it, and do real prepare.
// so here is a defense, avoid ps prepare reuse wrong.
// if for some reason, ps reuse this, we can make sure result is correct.
param_field.inout_mode_ = ObRoutineParamInOut::SP_PARAM_INOUT;
OZ (result.add_param_column(param_field), K(param_field), K(i), K(param_cnt));
}
}
} else {
if (context.is_dynamic_sql_ && !context.is_dbms_sql_) {
parse_result.input_sql_ = parse_result.no_param_sql_;
@ -1896,6 +1918,14 @@ int ObSql::handle_ps_prepare(const ObString &stmt,
*stmt_info,
is_expired))) {
LOG_WARN("fail to check schema version", K(ret));
} else if (!is_expired
&& !context.is_pre_execute_ // ps prepare
&& stmt_info->get_is_prexecute() // prexecute prepare
&& stmt::T_ANONYMOUS_BLOCK == stmt_info->get_stmt_type()
&& FALSE_IT(is_expired = true)) {
// prexecute prepare anonymous block result can not reused by ps prepare.
// but ps prepare anonymous block can reused by prexecute.
// here, we replace to ps prepare result.
} else if (is_expired) {
stmt_info->set_is_expired();
if (OB_FAIL(ps_cache->erase_stmt_item(inner_stmt_id, ps_key))) {