diff --git a/src/sql/optimizer/ob_logical_operator.cpp b/src/sql/optimizer/ob_logical_operator.cpp index 373749a144..934086d8e2 100644 --- a/src/sql/optimizer/ob_logical_operator.cpp +++ b/src/sql/optimizer/ob_logical_operator.cpp @@ -321,7 +321,7 @@ int ObAllocExprContext::add(const ExprProducer &producer) if (OB_FAIL(expr_producers_.push_back(producer))) { LOG_WARN("failed to push back producer", K(ret)); } else if (expr_producers_.count() == 1 && - expr_map_.create(128, "ExprAlloc")) { + OB_FAIL(expr_map_.create(128, "ExprAlloc"))) { LOG_WARN("failed to init hash map", K(ret)); } else if (OB_FAIL(expr_map_.set_refactored(reinterpret_cast(producer.expr_), expr_producers_.count() - 1))) { diff --git a/src/sql/optimizer/ob_skyline_prunning.cpp b/src/sql/optimizer/ob_skyline_prunning.cpp index b41e857904..aa689ea65c 100644 --- a/src/sql/optimizer/ob_skyline_prunning.cpp +++ b/src/sql/optimizer/ob_skyline_prunning.cpp @@ -652,7 +652,6 @@ int ObSkylineDimRecorder::add_index_dim(const ObIndexSkylineDim &dim, bool &has_ OPT_TRACE("Index can not be pruning"); } else { if (OB_FAIL(has_dominate_dim(dim, remove_idxs, need_add))) { - ret = OB_ERR_UNEXPECTED; LOG_WARN("check has dominate index failed", K(dim)); } else if (need_add) { //remove from back, idx id is in ascending order