hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] [CP] fix incorrect construct sql from update statement

Browse Source
This commit is contained in:
obdev 2022-11-30 08:38:08 +00:00 committed by ob-robot
parent 5784351a1c
commit 3e08049b73
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/sql/resolver/dml/ob_del_upd_resolver.cpp
View File

@ -630,7 +630,7 @@ int ObDelUpdResolver::add_assignment(common::ObIArray<ObTableAssignment> &assign
ObTableAssignment *table_assign = NULL; ObTableAssignment *table_assign = NULL;
int64_t N = assigns.count(); int64_t N = assigns.count();
if (OB_ISNULL(schema_checker_) || OB_ISNULL(table_item) || OB_ISNULL(assign.column_expr_) if (OB_ISNULL(schema_checker_) || OB_ISNULL(table_item) || OB_ISNULL(assign.column_expr_)
|| OB_ISNULL(get_stmt())) { || OB_ISNULL(get_stmt()) || OB_ISNULL(get_stmt()->get_query_ctx())) {
ret = OB_INVALID_ARGUMENT; ret = OB_INVALID_ARGUMENT;
LOG_WARN("invalid argument", K(ret), K_(schema_checker), K(table_item), K_(assign.column_expr)); LOG_WARN("invalid argument", K(ret), K_(schema_checker), K(table_item), K_(assign.column_expr));
} else if (assign.column_expr_->get_result_type().is_lob() } else if (assign.column_expr_->get_result_type().is_lob()
@ -672,11 +672,15 @@ int ObDelUpdResolver::add_assignment(common::ObIArray<ObTableAssignment> &assign
} }
} }
bool found = false; bool found = false;
for (int64_t i = 0; OB_SUCC(ret) && !found && i < table_assign->assignments_.count(); ++i) { if (get_stmt()->get_query_ctx()->is_prepare_stmt()) {
if (assign.column_expr_ == table_assign->assignments_.at(i).column_expr_) { // do nothing
table_assign->assignments_.at(i) = assign; } else {
table_assign->assignments_.at(i).is_duplicated_ = true; //this column was updated repeatedly for (int64_t i = 0; OB_SUCC(ret) && !found && i < table_assign->assignments_.count(); ++i) {
found = true; if (assign.column_expr_ == table_assign->assignments_.at(i).column_expr_) {
table_assign->assignments_.at(i) = assign;
table_assign->assignments_.at(i).is_duplicated_ = true; //this column was updated repeatedly
found = true;
}
} }
} }