hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[mysql][window function]: fix 4 order by bugs in ob-mysql window function.

Browse Source
This commit is contained in:
Monk-Liu
2022-03-28 16:34:46 +08:00
committed by LINxiansheng
parent 5e0b6e4c8c
commit 403f881b89
10 changed files with 461 additions and 289 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
src/sql/resolver/dml/ob_select_resolver.cpp
View File

@ -4976,8 +4976,10 @@ int ObSelectResolver::resolve_win_func_exprs(ObRawExpr*& expr, common::ObIArray<
LOG_WARN("failed to handle compat with mysql ntile.", K(ret));
} else if (N >= OB_MAX_WINDOW_FUNCTION_NUM) {
ret = OB_ERR_INVALID_WINDOW_FUNC_USE;
LOG_WARN("invalid window func num", K(ret), K(N), K(OB_MAX_WINDOW_FUNCTION_NUM));
} else if (OB_FAIL(check_orderby_type_validity(win_expr))) {
// need to check order by here, since the basic column type is resolve
LOG_WARN("invalid window func orderby type", K(ret), K(*win_expr));
} else if (OB_ISNULL(final_win_expr = select_stmt->get_same_win_func_item(win_expr))) {
ret = select_stmt->add_window_func_expr(win_expr);
} else if (ObRawExprUtils::replace_ref_column(expr, win_exprs.at(i), final_win_expr)) {
@ -5542,7 +5544,49 @@ int ObSelectResolver::identify_anchor_member(
return ret;
}
int ObSelectResolver::check_ntile_compatiable_with_mysql(ObWinFunRawExpr* win_expr)
int ObSelectResolver::check_orderby_type_validity(ObWinFunRawExpr *win_expr)
{
int ret = OB_SUCCESS;
if (OB_ISNULL(win_expr)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("win expr is null.", K(ret));
} else if (win_expr->has_order_items() && win_expr->win_type_ == WINDOW_RANGE &&
(win_expr->get_upper().type_ == BOUND_INTERVAL || win_expr->get_lower().type_ == BOUND_INTERVAL)) {
for (int64_t i = 0; OB_SUCC(ret) && i < win_expr->order_items_.count(); i++) {
const OrderItem order_item = win_expr->order_items_.at(i);
if (OB_ISNULL(order_item.expr_)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("win expr unexpected null order by", K(ret));
} else if (OB_FAIL(order_item.expr_->formalize(session_info_))) {
LOG_WARN("order item can't be formalized", K(ret));
} else {
ObObjType data_type = order_item.expr_->get_data_type();
if (share::is_mysql_mode()) {
if (data_type == 0 || // NULL
ob_is_int_tc(data_type) || ob_is_uint_tc(data_type) || ob_is_float_tc(data_type) ||
ob_is_double_tc(data_type) || ob_is_number_tc(data_type) || ob_is_datetime_tc(data_type) ||
ob_is_date_tc(data_type) || ob_is_otimestampe_tc(data_type) || ob_is_time_tc(data_type) ||
ob_is_year_tc(data_type)) {
// in mysql, only the above types are allowed in window order by.
} else {
ret = OB_ERR_WINDOW_RANGE_FRAME_ORDER_TYPE;
LOG_WARN("RANGE N PRECEDING/FOLLOWING frame order by type miss match", K(ret), K(data_type));
}
} else {
if (ob_is_number_tc(data_type) || ob_is_datetime_tc(data_type)) {
// the above type are allowed in oracle
} else {
ret = OB_ERR_INVALID_WINDOW_FUNC_USE;
LOG_WARN("invalid datatype in order by for range clause", K(ret), K(data_type));
}
}
}
}
}
return ret;
}
int ObSelectResolver::check_ntile_compatiable_with_mysql(ObWinFunRawExpr *win_expr)
{
int ret = OB_SUCCESS;
if (OB_ISNULL(win_expr)) {