hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix a memleak caused by not release inner sql conn immediately when start trans failed in remote obs

Browse Source
This commit is contained in:
obdev
2023-02-09 13:49:09 +00:00
committed by ob-robot
parent 47f6c569cc
commit 41eb9a94e0
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/observer/ob_inner_sql_rpc_processor.cpp
View File

@ -666,11 +666,16 @@ int ObInnerSqlRpcP::process()
} }
if (OB_NOT_NULL(conn)) { if (OB_NOT_NULL(conn)) {
bool need_reuse_conn = true; bool need_reuse_conn = true;
const bool in_trans = OB_INVALID_ID != transmit_arg.get_conn_id() || ObInnerSQLTransmitArg::OPERATION_TYPE_START_TRANSACTION == transmit_arg.get_operation_type(); const bool is_start_trans = ObInnerSQLTransmitArg::OPERATION_TYPE_START_TRANSACTION
if (!in_trans // need to release conn if not in a trans == transmit_arg.get_operation_type();
const bool in_trans = is_start_trans || OB_INVALID_ID != transmit_arg.get_conn_id();
if (!in_trans
// need to release conn if not in a trans
|| ObInnerSQLTransmitArg::OPERATION_TYPE_ROLLBACK == transmit_arg.get_operation_type() || ObInnerSQLTransmitArg::OPERATION_TYPE_ROLLBACK == transmit_arg.get_operation_type()
|| ObInnerSQLTransmitArg::OPERATION_TYPE_COMMIT == transmit_arg.get_operation_type() || ObInnerSQLTransmitArg::OPERATION_TYPE_COMMIT == transmit_arg.get_operation_type()
// need to release conn after commit or rollback // need to release conn after commit or rollback
|| (OB_FAIL(ret) && is_start_trans)
// need to release conn if start_trans was failed
) { ) {
need_reuse_conn = false; need_reuse_conn = false;
} }