hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix a join elimination bug

Browse Source
This commit is contained in:
xianyu-w 2023-04-22 14:24:04 +00:00 committed by ob-robot
parent 27783b2352
commit 45b9626966
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/sql/rewrite/ob_transform_join_elimination.cpp
View File

@ -1558,7 +1558,7 @@ int ObTransformJoinElimination::check_all_column_primary_key(const ObDMLStmt *st
LOG_WARN("parameters have null", K(ret), K(stmt), K(info));
} else {
const ObIArray<ColumnItem> &all_columns = stmt->get_column_items();
for(int64_t i = 0; all_primary_key && i < all_columns.count(); ++i) {
for(int64_t i = 0; all_primary_key && OB_SUCC(ret) && i < all_columns.count(); ++i) {
const ColumnItem &item = all_columns.at(i);
if(item.table_id_ == table_id) {
bool find = false;
@ -1569,6 +1569,17 @@ int ObTransformJoinElimination::check_all_column_primary_key(const ObDMLStmt *st
}
all_primary_key = find;
}
if (all_primary_key) {
const ObExprResType *res_type = item.get_column_type();
if (OB_ISNULL(res_type)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("unexpected null", K(ret));
} else {
// Only replace exprs with bin sort foreign keys
all_primary_key = !ob_is_string_type(res_type->get_type()) ||
ObCharset::is_bin_sort(res_type->get_collation_type());
}
}
}
}
return ret;