hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[CP] Check ret code for ObSqlBitSet::add_member()

Browse Source
This commit is contained in:
obdev
2022-10-03 20:03:27 +00:00
committed by wangzelin.wzl
parent 7d285d45d4
commit 493b2fb2e2
11 changed files with 69 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/sql/rewrite/ob_transform_pre_process.cpp
View File

@ -2724,7 +2724,6 @@ int ObTransformPreProcess::add_filter_for_temporary_table(ObDMLStmt& stmt, const
expr_col->set_table_name(table_item.get_table_name());
expr_col->set_column_name(OB_HIDDEN_SESSION_ID_COLUMN_NAME);
expr_col->set_ref_id(table_item.table_id_, OB_HIDDEN_SESSION_ID_COLUMN_ID);
expr_col->add_relation_id(stmt.get_table_bit_index(table_item.table_id_));
expr_col->set_collation_type(ObCharset::get_default_collation(ObCharset::get_default_charset()));
expr_col->set_collation_level(CS_LEVEL_SYSCONST);
expr_col->set_result_type(result_type);
@ -2733,7 +2732,9 @@ int ObTransformPreProcess::add_filter_for_temporary_table(ObDMLStmt& stmt, const
column_item.table_id_ = expr_col->get_table_id();
column_item.column_id_ = expr_col->get_column_id();
column_item.column_name_ = expr_col->get_column_name();
if (OB_FAIL(stmt.add_column_item(column_item))) {
if (OB_FAIL(expr_col->add_relation_id(stmt.get_table_bit_index(table_item.table_id_)))) {
LOG_WARN("failed to add relation id", K(ret));
} else if (OB_FAIL(stmt.add_column_item(column_item))) {
LOG_WARN("add column item to stmt failed", K(ret));
}
}