hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[CP] fix allocate gi above window function bug

Browse Source
This commit is contained in:
obdev
2022-07-31 20:29:55 +08:00
committed by wangzelin.wzl
parent f3f54ca0ea
commit 4942b97c45
3 changed files with 27 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/sql/optimizer/ob_log_group_by.cpp
View File

@ -27,6 +27,7 @@
#include "ob_raw_expr_push_down_aggr_expr.h"
#include "ob_select_log_plan.h"
#include "common/ob_smart_call.h"
#include "ob_log_window_function.h"
using namespace oceanbase;
using namespace sql;
@ -277,15 +278,15 @@ int ObLogGroupBy::allocate_groupby_below(const ObIArray<ObRawExpr*>& distinct_ex
// 2. distint expr is pushed down, such as count(distinct c1)
// a partition should not be processed by two px tasks, other the distinct result
// will be mis-estimated
bool find_exchange = false;
bool child_can_pullup_gi = true;
if (OB_ISNULL(child = child_group_by->get_child(first_child))) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("get unexpected null", K(child), K(ret));
} else if (OB_FAIL(child_group_by->get_sharding_info().copy_with_part_keys(child->get_sharding_info()))) {
LOG_WARN("failed to copy sharding info", K(ret));
} else if (OB_FAIL(child_has_exchange(child, find_exchange))) {
} else if (OB_FAIL(check_can_pullup_gi(child, child_can_pullup_gi))) {
LOG_WARN("fail to find tsc recursive");
} else if (!find_exchange) {
} else if (child_can_pullup_gi) {
child_group_by->set_is_partition_wise(true);
child_group_by->set_is_block_gi_allowed(!should_push_distinct);
} else { /*do nothing*/
@ -306,7 +307,27 @@ int ObLogGroupBy::allocate_groupby_below(const ObIArray<ObRawExpr*>& distinct_ex
return ret;
}
int ObLogGroupBy::get_group_rollup_exprs(common::ObIArray<ObRawExpr*>& group_rollup_exprs) const
// child has allocate exchange or parallel window function, can not pullup gi
int ObLogGroupBy::check_can_pullup_gi(const ObLogicalOperator *op, bool &can_pullup)
{
int ret = OB_SUCCESS;
if (OB_ISNULL(op) || !can_pullup) {
/*do nothing*/
} else if (log_op_def::LOG_EXCHANGE == op->get_type() ||
(log_op_def::LOG_WINDOW_FUNCTION == op->get_type() &&
static_cast<const ObLogWindowFunction *>(op)->is_parallel())) {
can_pullup = false;
} else {
for (int i = 0; OB_SUCC(ret) && can_pullup && i < op->get_num_of_child(); ++i) {
if (OB_FAIL(SMART_CALL(check_can_pullup_gi(op->get_child(i), can_pullup)))) {
LOG_WARN("fail to find tsc recursive", K(ret));
}
}
}
return ret;
}
int ObLogGroupBy::get_group_rollup_exprs(common::ObIArray<ObRawExpr *> &group_rollup_exprs) const
{
int ret = OB_SUCCESS;
if (OB_FAIL(append(group_rollup_exprs, group_exprs_))) {

1
src/sql/optimizer/ob_log_group_by.h
View File

@ -95,6 +95,7 @@ public:
int allocate_groupby_below(const ObIArray<ObRawExpr*>& distinct_exprs, const bool can_push,
ObLogicalOperator*& exchange_point,
common::ObIArray<std::pair<ObRawExpr*, ObRawExpr*> >& group_push_down_replaced_exprs);
int check_can_pullup_gi(const ObLogicalOperator *op, bool &can_pullup);
int should_push_down_group_by(AllocExchContext& ctx, ObIArray<ObRawExpr*>& distinct_exprs, bool& should_push_groupby,
bool& should_push_distinct);
virtual uint64_t hash(uint64_t seed) const override;

2
src/sql/optimizer/ob_log_window_function.h
View File

@ -46,7 +46,7 @@ public:
virtual int allocate_granule_pre(AllocGIContext& ctx) override;
int get_win_partition_intersect_exprs(ObIArray<ObWinFunRawExpr*>& win_exprs, ObIArray<ObRawExpr*>& win_part_exprs);
virtual int inner_append_not_produced_exprs(ObRawExprUniqueSet& raw_exprs) const override;
bool is_parallel()
bool is_parallel() const
{
return is_parallel_;
}