hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix outer join push down limit bug.

Browse Source
This commit is contained in:
my0 2021-09-07 18:01:03 +08:00 committed by wangzelin.wzl
parent ea1c67200f
commit 4a421098f7
2 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/sql/rewrite/ob_transform_outerjoin_limit_pushdown.cpp
View File

@ -128,12 +128,15 @@ int ObTransformOuterJoinLimitPushDown::check_basic(ObDMLStmt* stmt, OjLimitPushD
table_item = select_stmt->get_table_item(from_item);
JoinedTable* joined_table = static_cast<JoinedTable*>(table_item);
bool is_single_type = false;
bool has_generated_table = false;
// only left outer allowed after right->left transformation
// mixed join type, such as left & inner is NOT allowed
if (OB_FAIL(check_join_type(joined_table, LEFT_OUTER_JOIN, is_single_type))) {
if (OB_FAIL(check_join_type(joined_table, LEFT_OUTER_JOIN, is_single_type, has_generated_table))) {
LOG_WARN("failed to check deep tree type", K(ret));
} else if (!is_single_type) {
is_valid = false;
} else if (has_generated_table && select_stmt->get_condition_size() > 0) {
is_valid = false;
} else {
helper.select_stmt_ = select_stmt;
helper.is_limit_only_ = !select_stmt->has_order_by();
@ -238,7 +241,7 @@ int ObTransformOuterJoinLimitPushDown::check_offset_limit_expr(ObRawExpr* offset
}
int ObTransformOuterJoinLimitPushDown::check_join_type(
TableItem* table_item, ObJoinType joined_type, bool& is_single_type)
TableItem *table_item, ObJoinType joined_type, bool &is_single_type, bool &has_generated_table)
{
int ret = OB_SUCCESS;
is_single_type = true;
@ -246,13 +249,16 @@ int ObTransformOuterJoinLimitPushDown::check_join_type(
if (OB_ISNULL(table_item)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("invalid table item", K(ret));
} else if (table_item->is_basic_table() || table_item->is_generated_table()) {
} else if (table_item->is_basic_table()) {
// do nothing
} else if (table_item->is_joined_table() && static_cast<JoinedTable*>(table_item)->joined_type_ == joined_type) {
JoinedTable* joined_table = static_cast<JoinedTable*>(table_item);
} else if (table_item->is_generated_table()) {
has_generated_table = true;
} else if (table_item->is_joined_table() && static_cast<JoinedTable *>(table_item)->joined_type_ == joined_type) {
JoinedTable *joined_table = static_cast<JoinedTable *>(table_item);
// only need to check left side recursively after right to left formalization
bool is_left_single_type = false;
if (OB_FAIL(SMART_CALL(check_join_type(joined_table->left_table_, joined_type, is_left_single_type)))) {
if (OB_FAIL(SMART_CALL(
check_join_type(joined_table->left_table_, joined_type, is_left_single_type, has_generated_table)))) {
LOG_WARN("failed to check left child deep tree type", K(ret));
} else if (!is_left_single_type) {
is_single_type = false;
@ -506,7 +512,6 @@ int ObTransformOuterJoinLimitPushDown::pushdown_view_table(ObSelectStmt* stmt, T
LOG_WARN("failed to formalize generated_view", K(ret));
} else { /* do nothing */
}
return ret;
}

2
src/sql/rewrite/ob_transform_outerjoin_limit_pushdown.h
View File

@ -84,7 +84,7 @@ private:
int check_limit(ObSelectStmt* select_stmt, bool& is_valid);
int check_join_type(TableItem* table_item, ObJoinType joined_type, bool& is_type_deep);
int check_join_type(TableItem *table_item, ObJoinType joined_type, bool &is_type_deep, bool &has_generated_table);
int find_target_table(ObSelectStmt* select_stmt, ObSqlBitSet<> table_ids, TableItem*& target_table);