From 4e8a5b253ec6ef1dd69312c8f34a4cd38cd39a49 Mon Sep 17 00:00:00 2001 From: obdev Date: Tue, 29 Aug 2023 15:10:49 +0000 Subject: [PATCH] fix defensive check bug in WinMagic transform rule --- src/sql/rewrite/ob_transform_win_magic.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/sql/rewrite/ob_transform_win_magic.cpp b/src/sql/rewrite/ob_transform_win_magic.cpp index 90f8a4f9f9..649054aec2 100644 --- a/src/sql/rewrite/ob_transform_win_magic.cpp +++ b/src/sql/rewrite/ob_transform_win_magic.cpp @@ -1834,11 +1834,8 @@ int ObTransformWinMagic::check_join_push_down(ObDMLStmt *main_stmt, expr->get_relation_ids().has_member(view_table_idx) && expr->get_relation_ids().has_member(push_down_table_idx)) { ObSEArray column_exprs; - if (!expr->is_op_expr()) { + if (!expr->is_op_expr() || expr->get_param_count() < 2) { //do nothing - } else if (expr->get_param_count() < 2) { - ret = OB_ERR_UNEXPECTED; - LOG_WARN("equal expr param count is less than 2", K(ret)); } else if (OB_ISNULL(expr->get_param_expr(0)) || OB_ISNULL(expr->get_param_expr(1))) { ret = OB_ERR_UNEXPECTED;