hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] [CP] Disable pdml when primary key has auto increment column

Browse Source
This commit is contained in:
hezuojiao
2023-12-26 10:49:14 +00:00
committed by ob-robot
parent b0387b6039
commit 5451651fa1
5 changed files with 80 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sql/optimizer/ob_explain_note.h
View File

@ -35,6 +35,7 @@ namespace sql
#define PARALLEL_DISABLED_BY_PL_UDF_DAS "Degree of Parallelisim is %ld because stmt contain pl_udf which force das scan"
#define DIRECT_MODE_INSERT_INTO_SELECT "Direct-mode is enabled in insert into select"
#define PARALLEL_DISABLED_BY_DBLINK "Degree of Parallelisim is %ld because stmt contain dblink which force das scan"
#define PDML_DISABLED_BY_INSERT_PK_AUTO_INC "PDML disabled because the insert statement primary key has specified auto-increment column"
}
}

7
src/sql/optimizer/ob_insert_log_plan.cpp
View File

@ -325,6 +325,8 @@ int ObInsertLogPlan::check_need_online_stats_gather(bool &need_osg)
ObObj online_sys_var_obj;
const ObInsertStmt *insert_stmt = NULL;
TableItem *ins_table = NULL;
bool disable_pdml = false;
bool is_pk_auto_inc = false;
if (OB_ISNULL(insert_stmt = get_stmt()) ||
OB_ISNULL(ins_table = insert_stmt->get_table_item_by_id(insert_stmt->get_insert_table_info().table_id_))) {
ret = OB_ERR_UNEXPECTED;
@ -334,6 +336,11 @@ int ObInsertLogPlan::check_need_online_stats_gather(bool &need_osg)
|| !insert_stmt->value_from_select()
|| (!get_optimizer_context().get_session_info()->is_user_session())) {
need_gathering = false;
} else if (OB_FAIL(insert_stmt->check_pdml_disabled(get_optimizer_context().is_online_ddl(),
disable_pdml, is_pk_auto_inc))) {
LOG_WARN("fail to check pdml disable for insert stmt", K(ret));
} else if (disable_pdml) {
need_gathering = false;
}
if (OB_FAIL(ret)) {

11
src/sql/optimizer/ob_optimizer.cpp
View File

@ -332,6 +332,8 @@ int ObOptimizer::check_pdml_enabled(const ObDMLStmt &stmt,
bool session_enable_pdml = false;
bool enable_auto_dop = false;
uint64_t session_pdml_dop = ObGlobalHint::UNSET_PARALLEL;
bool disable_pdml = false;
bool is_pk_auto_inc = false;
if (OB_ISNULL(ctx_.get_exec_ctx()) || OB_ISNULL(query_ctx = ctx_.get_query_ctx())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("unexpected null", K(ret), K(ctx_.get_exec_ctx()), K(query_ctx));
@ -348,8 +350,15 @@ int ObOptimizer::check_pdml_enabled(const ObDMLStmt &stmt,
} else if (ctx_.has_var_assign() && !ctx_.is_var_assign_only_in_root_stmt()) {
can_use_pdml = false;
} else if (stmt::T_INSERT == stmt.get_stmt_type() &&
!static_cast< const ObInsertStmt &>(stmt).value_from_select()) {
OB_FAIL(static_cast< const ObInsertStmt &>(stmt).check_pdml_disabled(ctx_.is_online_ddl(),
disable_pdml,
is_pk_auto_inc))) {
LOG_WARN("fail to check pdml disabled for insert stmt", K(ret));
} else if (disable_pdml) {
can_use_pdml = false;
if (is_pk_auto_inc) {
ctx_.add_plan_note(PDML_DISABLED_BY_INSERT_PK_AUTO_INC);
}
} else if ((stmt.is_update_stmt() || stmt.is_delete_stmt())
&& static_cast<const ObDelUpdStmt &>(stmt).dml_source_from_join()
&& static_cast<const ObDelUpdStmt &>(stmt).is_dml_table_from_join()) {