hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] Resolve the issue of not checking whether all_dfos is empty when clearing interm results.

Browse Source
This commit is contained in:
qingsuijiu 2024-12-13 04:15:35 +00:00 committed by ob-robot
parent 0db002c61d
commit 56ac45db1c
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/sql/engine/px/ob_dfo_scheduler.cpp
View File

@ -626,10 +626,13 @@ void ObSerialDfoScheduler::clean_dtl_interm_result(ObExecContext &exec_ctx)
{
int ret = OB_SUCCESS;
const ObIArray<ObDfo *> &all_dfos = coord_info_.dfo_mgr_.get_all_dfos();
ObDfo *last_dfo = all_dfos.at(all_dfos.count() - 1);
ObDfo *last_dfo = nullptr;
int clean_ret = OB_E(EventTable::EN_ENABLE_CLEAN_INTERM_RES) OB_SUCCESS;
if (clean_ret != OB_SUCCESS) {
// Fault injection: Do not clean up interm results.
} else if (all_dfos.empty()) {
// do nothing
} else if (FALSE_IT(last_dfo = all_dfos.at(all_dfos.count() - 1))) {
} else if (OB_NOT_NULL(last_dfo) && last_dfo->is_scheduled() && OB_NOT_NULL(last_dfo->parent())
&& last_dfo->parent()->is_root_dfo()) {
// all dfo scheduled, do nothing.