From 5af9d6c36d8fe180770ab4a36ede425f833e5fab Mon Sep 17 00:00:00 2001 From: obdev Date: Tue, 30 May 2023 04:46:48 +0000 Subject: [PATCH] Fix memory leak introduce by change revert logic of lookup op. --- src/sql/das/ob_das_group_scan_op.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/sql/das/ob_das_group_scan_op.cpp b/src/sql/das/ob_das_group_scan_op.cpp index 2ae3ff9cc6..cfe5fc265c 100644 --- a/src/sql/das/ob_das_group_scan_op.cpp +++ b/src/sql/das/ob_das_group_scan_op.cpp @@ -365,10 +365,9 @@ int ObGroupLookupOp::set_lookup_scan_group(int64_t group_id) int ObGroupLookupOp::revert_iter() { int ret = OB_SUCCESS; - /* - * ObLookupOp will call ObLocalIndexLookupOp::revert_iter(); - * We do not need revert twice! - */ + if (OB_FAIL(ObLocalIndexLookupOp::revert_iter())) { + LOG_WARN("revert local index lookup iter from group fail.", K(ret)); + } group_iter_.reset(); return ret; }