hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix bugs that lost stmt scala group by property after remove all aggr_items

Browse Source
This commit is contained in:
jingtaoye35
2023-11-20 14:49:02 +00:00
committed by ob-robot
parent d4a411c686
commit 5b56913d35
13 changed files with 94 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/sql/resolver/expr/ob_raw_expr_util.cpp
View File

@ -8789,5 +8789,29 @@ bool ObRawExprUtils::is_column_ref_skip_implicit_cast(const ObRawExpr *expr)
return bret;
}
int ObRawExprUtils::build_dummy_count_expr(ObRawExprFactory &expr_factory,
const ObSQLSessionInfo *session_info,
ObAggFunRawExpr *&expr)
{
int ret = OB_SUCCESS;
ObConstRawExpr *one_expr = NULL;
ObAggFunRawExpr *count_expr = NULL;
if (OB_FAIL(build_const_int_expr(expr_factory, ObInt32Type, static_cast<int32_t>(1), one_expr))) {
LOG_WARN("failed build const int expr for default expr", K(ret));
} else if (OB_ISNULL(one_expr)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("operator is unexpected null", K(ret));
} else if (OB_FAIL(expr_factory.create_raw_expr(T_FUN_COUNT, count_expr))) {
LOG_WARN("fail to create const raw expr", K(ret));
} else if (OB_FAIL(count_expr->add_real_param_expr(one_expr))) {
LOG_WARN("fail to push back", K(ret));
} else if (OB_FAIL(count_expr->formalize(session_info))) {
LOG_WARN("failed to extract expr info", K(ret));
} else {
expr = count_expr;
}
return ret;
}
}
}

3
src/sql/resolver/expr/ob_raw_expr_util.h
View File

@ -1147,6 +1147,9 @@ public:
static int check_is_valid_generated_col(ObRawExpr *expr, ObIAllocator &allocator);
static bool is_column_ref_skip_implicit_cast(const ObRawExpr *expr);
static int build_dummy_count_expr(ObRawExprFactory &expr_factory,
const ObSQLSessionInfo *session_info,
ObAggFunRawExpr *&expr);
private :
static int create_real_cast_expr(ObRawExprFactory &expr_factory,