hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix for update wait parser does not support decimal number

Browse Source
This commit is contained in:
hy-guo
2024-01-22 13:17:09 +00:00
committed by ob-robot
parent 925a77ec67
commit 5b88653ed2
1 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/sql/resolver/dml/ob_select_resolver.cpp
View File

@ -1417,6 +1417,27 @@ int ObSelectResolver::resolve_for_update_clause_oracle(const ParseNode &node)
// nowait wait_us = 0;
wait_us = wait_or_skip_node->value_ * 1000000LL;
skip_locked = false;
} else if (wait_or_skip_node->type_ == T_SFU_DECIMAL) {
// "select * from t1 for update wait 1.0;" is same as "wait 1"
// "select * from t1 for update wait 1.5;" throw OB_ERR_REQUIRE_INTEGER
ObNumber value;
ObString time_str(wait_or_skip_node->str_len_, wait_or_skip_node->str_value_);
if (OB_ISNULL(allocator_)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("allocator is null", K(ret));
} else if (OB_FAIL(value.from(wait_or_skip_node->str_value_,
wait_or_skip_node->str_len_,
*allocator_))) {
LOG_WARN("from number failed", K(ret));
} else if (OB_UNLIKELY(!value.is_valid_int())) {
ret = OB_ERR_REQUIRE_INTEGER;
LOG_WARN("wait time not a integer value", K(ret), K(value));
} else if (OB_FAIL(ObTimeUtility2::str_to_time(
time_str, wait_us, ObTimeUtility2::DIGTS_SENSITIVE))) {
LOG_WARN("str to time failed", K(ret));
} else {
skip_locked = false;
}
}
} else {
wait_us = -1;