hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix late materialization bug

Browse Source
This commit is contained in:
obdev
2024-02-06 20:34:06 +00:00
committed by ob-robot
parent cdff7836ec
commit 611d2d3d72
2 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/sql/optimizer/ob_select_log_plan.cpp
View File

@ -7210,6 +7210,7 @@ int ObSelectLogPlan::if_plan_need_late_materialization(ObLogicalOperator *top,
ObLogSort *child_sort = NULL; ObLogSort *child_sort = NULL;
ObLogTableScan *table_scan = NULL; ObLogTableScan *table_scan = NULL;
ObSEArray<uint64_t, 4> used_column_ids; ObSEArray<uint64_t, 4> used_column_ids;
bool contain_enumset_rowkey = false;
if (OB_ISNULL(top) || OB_ISNULL(stmt = get_stmt())) { if (OB_ISNULL(top) || OB_ISNULL(stmt = get_stmt())) {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
LOG_WARN("get unexpected null", K(top), K(get_stmt()), K(ret)); LOG_WARN("get unexpected null", K(top), K(get_stmt()), K(ret));
@ -7221,6 +7222,10 @@ int ObSelectLogPlan::if_plan_need_late_materialization(ObLogicalOperator *top,
NULL == table_scan->get_plan() || NULL == table_scan->get_plan() ||
NULL == child_sort) { NULL == child_sort) {
//do nothing //do nothing
} else if (OB_FAIL(contain_enum_set_rowkeys(*table_scan, contain_enumset_rowkey))) {
LOG_WARN("check whether table has enumset rowkey failed", K(ret));
} else if (contain_enumset_rowkey) {
//if there are enumset rowkeys, don't use late materialization since 'enumset_col = ?' cannot be used to extract query ranges
} else if (OB_FAIL(if_index_back_plan_need_late_materialization(child_sort, } else if (OB_FAIL(if_index_back_plan_need_late_materialization(child_sort,
table_scan, table_scan,
used_column_ids, used_column_ids,
@ -7627,5 +7632,26 @@ int ObSelectLogPlan::check_external_table_scan(ObSelectStmt *stmt, bool &has_ext
return ret; return ret;
} }
int ObSelectLogPlan::contain_enum_set_rowkeys(const ObLogTableScan &table_scan, bool &contain) {
int ret = OB_SUCCESS;
ObSEArray<ObRawExpr*, 4> table_keys;
contain = false;
if (OB_FAIL(get_rowkey_exprs(table_scan.get_table_id(),
table_scan.get_ref_table_id(),
table_keys))) {
LOG_WARN("failed to generate rowkey exprs", K(ret));
} else {
for (int64_t i = 0; OB_SUCC(ret) && !contain && i < table_keys.count(); ++i) {
if (OB_ISNULL(table_keys.at(i))) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("row key is null", K(ret));
} else if (ob_is_enumset_tc(table_keys.at(i)->get_result_type().get_type())) {
contain = true;
}
}
}
return ret;
}
}//sql }//sql
}//oceanbase }//oceanbase

2
src/sql/optimizer/ob_select_log_plan.h
View File

@ -883,6 +883,8 @@ private:
int check_external_table_scan(ObSelectStmt *stmt, bool &has_external_table); int check_external_table_scan(ObSelectStmt *stmt, bool &has_external_table);
int contain_enum_set_rowkeys(const ObLogTableScan &table_scan, bool &contain);
DISALLOW_COPY_AND_ASSIGN(ObSelectLogPlan); DISALLOW_COPY_AND_ASSIGN(ObSelectLogPlan);
}; };
}//end of namespace sql }//end of namespace sql