hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

disable transform stmt which has instead of trigger

Browse Source
This commit is contained in:
xianyu-w
2023-07-25 14:54:34 +00:00
committed by ob-robot
parent 8c16a5e83c
commit 64d1ec452f
2 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/sql/code_generator/ob_dml_cg_service.cpp
View File

@ -2016,12 +2016,31 @@ int ObDmlCgService::convert_normal_triggers(ObLogDelUpd &log_op,
LOG_DEBUG("debug trigger normal column", K(ret), K(is_instead_of), LOG_DEBUG("debug trigger normal column", K(ret), K(is_instead_of),
K(dml_ctdef.old_row_.count()), K(dml_ctdef.new_row_.count())); K(dml_ctdef.old_row_.count()), K(dml_ctdef.new_row_.count()));
if (ObTriggerEvents::is_insert_event(dml_event)) { if (ObTriggerEvents::is_insert_event(dml_event)) {
new_expr = dml_ctdef.new_row_.at(col_idx); if (OB_UNLIKELY(col_idx < 0) ||
OB_UNLIKELY(col_idx >= dml_ctdef.new_row_.count())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("unexpected col idx", K(col_idx), K(dml_ctdef.new_row_));
} else {
new_expr = dml_ctdef.new_row_.at(col_idx);
}
} else if (ObTriggerEvents::is_update_event(dml_event)) { } else if (ObTriggerEvents::is_update_event(dml_event)) {
new_expr = dml_ctdef.new_row_.at(col_idx); if (OB_UNLIKELY(col_idx < 0) ||
old_expr = dml_ctdef.old_row_.at(col_idx); OB_UNLIKELY(col_idx >= dml_ctdef.new_row_.count()) ||
OB_UNLIKELY(col_idx >= dml_ctdef.old_row_.count())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("unexpected col idx", K(col_idx), K(dml_ctdef.new_row_), K(dml_ctdef.old_row_));
} else {
new_expr = dml_ctdef.new_row_.at(col_idx);
old_expr = dml_ctdef.old_row_.at(col_idx);
}
} else if (ObTriggerEvents::is_delete_event(dml_event)) { } else if (ObTriggerEvents::is_delete_event(dml_event)) {
old_expr = dml_ctdef.old_row_.at(col_idx); if (OB_UNLIKELY(col_idx < 0) ||
OB_UNLIKELY(col_idx >= dml_ctdef.old_row_.count())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("unexpected col idx", K(col_idx), K(dml_ctdef.old_row_));
} else {
old_expr = dml_ctdef.old_row_.at(col_idx);
}
} else { } else {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
LOG_WARN("unexpected status: not supported dml type", LOG_WARN("unexpected status: not supported dml type",

3
src/sql/rewrite/ob_transform_rule.cpp
View File

@ -624,6 +624,9 @@ int ObTransformRule::need_transform(const common::ObIArray<ObParentDMLStmt> &par
if (is_normal_disabled_transform(stmt)) { if (is_normal_disabled_transform(stmt)) {
need_trans = false; need_trans = false;
OPT_TRACE("hierarchical query or insert query can not transform"); OPT_TRACE("hierarchical query or insert query can not transform");
} else if (stmt.has_instead_of_trigger()) {
need_trans = false;
OPT_TRACE("stmt with instead of trigger can not transform");
} else if (OB_FAIL(check_hint_status(stmt, need_trans))) { } else if (OB_FAIL(check_hint_status(stmt, need_trans))) {
LOG_WARN("failed to check hint status", K(ret)); LOG_WARN("failed to check hint status", K(ret));
} }