hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: fix the mem leak induced by create hash set for distinct check

Browse Source
This commit is contained in:
obdev
2023-02-15 04:16:58 +00:00
committed by ob-robot
parent e0f9403d72
commit 6597151e89
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/engine/dml/ob_dml_service.cpp
View File

@ -1274,6 +1274,10 @@ int ObDMLService::init_del_rtdef(ObDMLRtCtx &dml_rtctx,
if (OB_FAIL(ObDMLService::create_rowkey_check_hashset(dml_op.get_spec().rows_, root_ctx, del_ctx.deleted_rows_))) { if (OB_FAIL(ObDMLService::create_rowkey_check_hashset(dml_op.get_spec().rows_, root_ctx, del_ctx.deleted_rows_))) {
LOG_WARN("failed to create hash set", K(ret)); LOG_WARN("failed to create hash set", K(ret));
} else if (OB_FAIL(del_ctx_list.push_back(del_ctx))) { } else if (OB_FAIL(del_ctx_list.push_back(del_ctx))) {
if (nullptr != del_ctx.deleted_rows_) {
del_ctx.deleted_rows_->destroy();
del_ctx.deleted_rows_ = nullptr;
}
LOG_WARN("failed to push del ctx to list", K(ret)); LOG_WARN("failed to push del ctx to list", K(ret));
} else { } else {
del_rtdef.se_rowkey_dist_ctx_ = del_ctx.deleted_rows_; del_rtdef.se_rowkey_dist_ctx_ = del_ctx.deleted_rows_;
@ -1293,7 +1297,10 @@ int ObDMLService::init_del_rtdef(ObDMLRtCtx &dml_rtctx,
} else if (OB_FAIL(ObDMLService::create_rowkey_check_hashset(dml_op.get_spec().rows_, root_ctx, del_ctx.deleted_rows_))) { } else if (OB_FAIL(ObDMLService::create_rowkey_check_hashset(dml_op.get_spec().rows_, root_ctx, del_ctx.deleted_rows_))) {
LOG_WARN("failed to create hash set", K(ret)); LOG_WARN("failed to create hash set", K(ret));
} else if (OB_FAIL(del_ctx_list.push_back(del_ctx))) { } else if (OB_FAIL(del_ctx_list.push_back(del_ctx))) {
LOG_WARN("failed to push del ctx to list", K(ret)); if (nullptr != del_ctx.deleted_rows_) {
del_ctx.deleted_rows_->destroy();
del_ctx.deleted_rows_ = nullptr;
}
} else { } else {
del_rtdef.se_rowkey_dist_ctx_ = del_ctx.deleted_rows_; del_rtdef.se_rowkey_dist_ctx_ = del_ctx.deleted_rows_;
} }