From 661a385292ce680bb2b34e8ce8b2a9c65ae81fd0 Mon Sep 17 00:00:00 2001 From: hiddenbomb Date: Tue, 3 Sep 2024 10:18:31 +0000 Subject: [PATCH] modify code owner --- mittest/mtlenv/storage/test_tablet_status_cache.cpp | 2 +- src/share/inner_table/ob_inner_table_schema_def.py | 6 +++--- src/storage/ls/ob_ls_tablet_service.cpp | 2 +- src/storage/meta_mem/ob_tenant_meta_mem_mgr.cpp | 2 +- .../multi_data_source/adapter_define/mds_dump_node.cpp | 2 +- .../multi_data_source/ob_start_transfer_in_mds_ctx.cpp | 2 +- src/storage/multi_data_source/ob_tablet_create_mds_ctx.cpp | 2 +- src/storage/tablet/ob_i_tablet_mds_interface.h | 4 ++-- src/storage/tablet/ob_mds_range_query_iterator.h | 2 +- src/storage/tablet/ob_mds_row_iterator.cpp | 2 +- src/storage/tablet/ob_mds_schema_helper.h | 2 +- src/storage/tablet/ob_tablet.h | 4 ++-- src/storage/tablet/ob_tablet_create_delete_helper.cpp | 2 +- src/storage/tablet/ob_tablet_mds_data.cpp | 2 +- src/storage/tablet/ob_tablet_medium_info_reader.cpp | 2 +- src/storage/tablet/ob_tablet_meta.cpp | 2 +- tools/deploy/mysql_test/test_suite/msdt/t/hidden_table.test | 2 +- tools/deploy/mysql_test/test_suite/msdt/t/lob.test | 2 +- 18 files changed, 22 insertions(+), 22 deletions(-) diff --git a/mittest/mtlenv/storage/test_tablet_status_cache.cpp b/mittest/mtlenv/storage/test_tablet_status_cache.cpp index 6f092c58a..2a47669dd 100644 --- a/mittest/mtlenv/storage/test_tablet_status_cache.cpp +++ b/mittest/mtlenv/storage/test_tablet_status_cache.cpp @@ -757,7 +757,7 @@ TEST_F(TestTabletStatusCache, read_all_committed) ASSERT_EQ(OB_SUCCESS, ret); } -// TODO(@bowen.gbw): refactor test cases to cover all scene +// TODO(@gaishun.gs): refactor test cases to cover all scene /* TEST_F(TestTabletStatusCache, transfer_src_ls_read_all_committed) { diff --git a/src/share/inner_table/ob_inner_table_schema_def.py b/src/share/inner_table/ob_inner_table_schema_def.py index a699920ef..428c28081 100644 --- a/src/share/inner_table/ob_inner_table_schema_def.py +++ b/src/share/inner_table/ob_inner_table_schema_def.py @@ -3155,7 +3155,7 @@ def_table_schema( ) all_tenant_directory_def = dict( - owner = 'bowen.gbw', + owner = 'jiahua.cjh', table_name = '__all_tenant_directory', table_id = '326', table_type = 'SYSTEM_TABLE', @@ -61542,7 +61542,7 @@ def_table_schema( ) def_table_schema( - owner = 'bowen.gbw', + owner = 'jiahua.cjh', table_name = 'ALL_DIRECTORIES', database_id = 'OB_ORA_SYS_DATABASE_ID', table_id = '28099', @@ -61564,7 +61564,7 @@ def_table_schema( ) def_table_schema( - owner = 'bowen.gbw', + owner = 'jiahua.cjh', table_name = 'DBA_DIRECTORIES', database_id = 'OB_ORA_SYS_DATABASE_ID', table_id = '28100', diff --git a/src/storage/ls/ob_ls_tablet_service.cpp b/src/storage/ls/ob_ls_tablet_service.cpp index 6ee2b10ba..8aa7409f8 100644 --- a/src/storage/ls/ob_ls_tablet_service.cpp +++ b/src/storage/ls/ob_ls_tablet_service.cpp @@ -224,7 +224,7 @@ int ObLSTabletService::replay( LOG_WARN("failed to init replayer", K(ret), KP(log_buf), K(nbytes), K(pos), K(lsn), K(scn)); } else if (OB_FAIL(replayer_executor.execute(scn, ls_->get_ls_id(), tablet_id))) { if (OB_TABLET_NOT_EXIST == ret) { - ret = OB_SUCCESS; // TODO (bowen.gbw): unify multi data replay logic + ret = OB_SUCCESS; // TODO (gaishun.gs): unify multi data replay logic LOG_INFO("tablet does not exist, skip", K(ret), K(replayer_executor)); } else if (OB_TIMEOUT == ret) { LOG_INFO("replace timeout errno", KR(ret), K(replayer_executor)); diff --git a/src/storage/meta_mem/ob_tenant_meta_mem_mgr.cpp b/src/storage/meta_mem/ob_tenant_meta_mem_mgr.cpp index 8ddfa80e2..1803fe142 100644 --- a/src/storage/meta_mem/ob_tenant_meta_mem_mgr.cpp +++ b/src/storage/meta_mem/ob_tenant_meta_mem_mgr.cpp @@ -2111,7 +2111,7 @@ int ObTenantMetaMemMgr::compare_and_swap_tablet( if (OB_FAIL(ret)) { } else { - // TODO(@bowen.gbw): Currently, the order is: + // TODO(@gaishun.gs): Currently, the order is: // 1. CAS operation, let the newest tablet be visible // 2. check and set initial state on tablet pointer // But upper layer may get tablet between step 1 and 2, which will cause that upper layer cannot diff --git a/src/storage/multi_data_source/adapter_define/mds_dump_node.cpp b/src/storage/multi_data_source/adapter_define/mds_dump_node.cpp index 0ef094dbf..48a8bbfd4 100644 --- a/src/storage/multi_data_source/adapter_define/mds_dump_node.cpp +++ b/src/storage/multi_data_source/adapter_define/mds_dump_node.cpp @@ -372,7 +372,7 @@ int64_t MdsDumpKV::to_string(char *buf, const int64_t buf_len) const bool MdsDumpKV::is_valid() const { - return k_.is_valid() && v_.is_valid(); // TODO(@bowen.gbw): add more rules + return k_.is_valid() && v_.is_valid(); // TODO(@gaishun.gs): add more rules } int MdsDumpKV::assign(const MdsDumpKV &rhs, ObIAllocator &alloc) diff --git a/src/storage/multi_data_source/ob_start_transfer_in_mds_ctx.cpp b/src/storage/multi_data_source/ob_start_transfer_in_mds_ctx.cpp index eb4710591..515b5927f 100644 --- a/src/storage/multi_data_source/ob_start_transfer_in_mds_ctx.cpp +++ b/src/storage/multi_data_source/ob_start_transfer_in_mds_ctx.cpp @@ -58,7 +58,7 @@ void ObStartTransferInMdsCtx::on_abort(const share::SCN &abort_scn) { mds::MdsCtx::on_abort(abort_scn); - // TODO(@bowen.gbw): feature branch transfer_dml_ctrl_42x patch to master, + // TODO(@gaishun.gs): feature branch transfer_dml_ctrl_42x patch to master, // then add more logic, currently this code is just for compat } diff --git a/src/storage/multi_data_source/ob_tablet_create_mds_ctx.cpp b/src/storage/multi_data_source/ob_tablet_create_mds_ctx.cpp index 0469ca7c0..cdf2b284b 100644 --- a/src/storage/multi_data_source/ob_tablet_create_mds_ctx.cpp +++ b/src/storage/multi_data_source/ob_tablet_create_mds_ctx.cpp @@ -45,7 +45,7 @@ void ObTabletCreateMdsCtx::on_abort(const share::SCN &abort_scn) { mds::MdsCtx::on_abort(abort_scn); - // TODO(@bowen.gbw): feature branch transfer_dml_ctrl_42x patch to master, + // TODO(@gaishun.gs): feature branch transfer_dml_ctrl_42x patch to master, // then add more logic, currently this code is just for compat } diff --git a/src/storage/tablet/ob_i_tablet_mds_interface.h b/src/storage/tablet/ob_i_tablet_mds_interface.h index b72c421d8..c946c7d85 100644 --- a/src/storage/tablet/ob_i_tablet_mds_interface.h +++ b/src/storage/tablet/ob_i_tablet_mds_interface.h @@ -33,7 +33,7 @@ class ObMdsRowIterator; class ObITabletMdsInterface { friend class ObTabletCreateDeleteHelper; - friend class ObTenantDirectLoadMgr; // TODO(@bowen.gbw): refactor later + friend class ObTenantDirectLoadMgr; // TODO(@gaishun.gs): refactor later public: // new mds // Currently, we only support read LATEST multi source data, so please pass MAX_SCN as snapshot. @@ -77,7 +77,7 @@ public: // CAUTIONS: this interface is only for transfer! anyone else shouldn't call this! int check_transfer_in_redo_written(bool &written); protected:// implemented by ObTablet - // TODO(@bowen.gbw): remove these virtual functions later + // TODO(@gaishun.gs): remove these virtual functions later virtual bool check_is_inited_() const = 0; virtual const ObTabletMeta &get_tablet_meta_() const = 0; virtual int get_mds_table_handle_(mds::MdsTableHandle &handle, diff --git a/src/storage/tablet/ob_mds_range_query_iterator.h b/src/storage/tablet/ob_mds_range_query_iterator.h index e5dcca490..4ebe81268 100644 --- a/src/storage/tablet/ob_mds_range_query_iterator.h +++ b/src/storage/tablet/ob_mds_range_query_iterator.h @@ -149,7 +149,7 @@ int ObMdsRangeQueryIterator::init( } else if (OB_FAIL(mds_sstable_iter_.init(scan_param, tablet_handle, store_ctx))) { MDS_LOG(WARN, "fail to init mds sstable iter", K(ret), K(scan_param)); } else { - // TODO(@bowen.gbw): currently we pass MAX_SCN as read snapshot, + // TODO(@gaishun.gs): currently we pass MAX_SCN as read snapshot, // in the future, we should consider the semantic of read snapshot when iteratively reading medium info. read_snapshot_.convert_for_tx(scan_param.frozen_version_); is_inited_ = true; diff --git a/src/storage/tablet/ob_mds_row_iterator.cpp b/src/storage/tablet/ob_mds_row_iterator.cpp index ddf21ed2c..eec21390e 100644 --- a/src/storage/tablet/ob_mds_row_iterator.cpp +++ b/src/storage/tablet/ob_mds_row_iterator.cpp @@ -189,7 +189,7 @@ int ObMdsRowIterator::convert( int ret = OB_SUCCESS; mds::MdsDumpKVStorageAdapter adapter; - // TODO(@bowen.gbw): avoid memory copy + // TODO(@gaishun.gs): avoid memory copy if (OB_FAIL(adapter.convert_from_mds_row(row))) { LOG_WARN("fail to convert from mds row", K(ret), K(row)); } else if (OB_FAIL(kv.convert_from_adapter(allocator, adapter))) { diff --git a/src/storage/tablet/ob_mds_schema_helper.h b/src/storage/tablet/ob_mds_schema_helper.h index c11457058..f92f6d538 100644 --- a/src/storage/tablet/ob_mds_schema_helper.h +++ b/src/storage/tablet/ob_mds_schema_helper.h @@ -88,7 +88,7 @@ public: static constexpr uint64_t META_INFO_IDX = 4; static constexpr uint64_t USER_DATA_IDX = 5; static constexpr int64_t MDS_SCHEMA_VERSION = 9527; // for mds schema change - static constexpr uint64_t MDS_TABLE_ID = 88888; // TODO(@bowen.gbw): choose another value? + static constexpr uint64_t MDS_TABLE_ID = 88888; // TODO(@gaishun.gs): choose another value? private: static constexpr const char *MDS_TABLE_NAME = "mds_table"; static constexpr const char *MDS_TYPE_COLUMN_NAME = "mds_type"; diff --git a/src/storage/tablet/ob_tablet.h b/src/storage/tablet/ob_tablet.h index f069e9f17..22dd789a1 100644 --- a/src/storage/tablet/ob_tablet.h +++ b/src/storage/tablet/ob_tablet.h @@ -218,7 +218,7 @@ public: const ObTablet &old_tablet, const bool clear_wait_check_flag); - // TODO(@bowen.gbw && @fengjingkun.fjk) tmp interface for force_freeze on column store, should removed later. + // TODO(@gaishun.gs && @fengjingkun.fjk) tmp interface for force_freeze on column store, should removed later. int init_with_new_snapshot_version( common::ObArenaAllocator &allocator, const ObTablet &old_tablet, @@ -657,7 +657,7 @@ private: int64_t get_self_serialize_size() const; static int check_schema_version(const ObDDLInfoCache& ddl_info_cache, const int64_t schema_version); static int check_snapshot_readable(const ObDDLInfoCache& ddl_info_cache, const int64_t snapshot_version, const int64_t schema_version); - logservice::ObLogHandler *get_log_handler() const { return log_handler_; } // TODO(bowen.gbw): get log handler from tablet pointer handle + logservice::ObLogHandler *get_log_handler() const { return log_handler_; } // TODO(gaishun.gs): get log handler from tablet pointer handle int init_shared_params( const share::ObLSID &ls_id, diff --git a/src/storage/tablet/ob_tablet_create_delete_helper.cpp b/src/storage/tablet/ob_tablet_create_delete_helper.cpp index 22d8033b1..daa166eaf 100644 --- a/src/storage/tablet/ob_tablet_create_delete_helper.cpp +++ b/src/storage/tablet/ob_tablet_create_delete_helper.cpp @@ -428,7 +428,7 @@ int ObTabletCreateDeleteHelper::check_read_snapshot_for_transfer_out( } else if (OB_FAIL(read_snapshot.convert_for_tx(snapshot_version))) { LOG_WARN("failed to convert from int64_t to SCN", K(ret), K(snapshot_version)); } else if (read_snapshot >= transfer_scn) { - // TODO(@bowen.gbw): TEMP SOLUTION, + // TODO(@gaishun.gs): TEMP SOLUTION, // return OB_TABLET_NOT_EXIST if read snapshot is no smaller than transfer scn, // no matter start transfer out transaction is committed or not. ret = OB_TABLET_NOT_EXIST; diff --git a/src/storage/tablet/ob_tablet_mds_data.cpp b/src/storage/tablet/ob_tablet_mds_data.cpp index 6740c9d25..f71f4fdad 100644 --- a/src/storage/tablet/ob_tablet_mds_data.cpp +++ b/src/storage/tablet/ob_tablet_mds_data.cpp @@ -142,7 +142,7 @@ void ObTabletMdsData::reset(common::ObIAllocator &allocator) bool ObTabletMdsData::is_valid() const { - // TODO(@bowen.gbw): add more check rules + // TODO(@gaishun.gs): add more check rules return is_inited_; } diff --git a/src/storage/tablet/ob_tablet_medium_info_reader.cpp b/src/storage/tablet/ob_tablet_medium_info_reader.cpp index 11a690912..da611e6da 100644 --- a/src/storage/tablet/ob_tablet_medium_info_reader.cpp +++ b/src/storage/tablet/ob_tablet_medium_info_reader.cpp @@ -103,7 +103,7 @@ int ObTabletMediumInfoReader::get_specified_medium_info( { int ret = OB_SUCCESS; - // TODO(@bowen.gbw): in the future we should use ObTablet::get_snapshot interface + // TODO(@gaishun.gs): in the future we should use ObTablet::get_snapshot interface mds::MdsDumpKV *kv = nullptr; compaction::ObMediumCompactionInfoKey tmp_key; bool found = false; diff --git a/src/storage/tablet/ob_tablet_meta.cpp b/src/storage/tablet/ob_tablet_meta.cpp index 578a02830..51358d74e 100644 --- a/src/storage/tablet/ob_tablet_meta.cpp +++ b/src/storage/tablet/ob_tablet_meta.cpp @@ -1024,7 +1024,7 @@ int ObTabletMeta::update_meta_last_persisted_committed_tablet_status( ObMigrationTabletParam::ObMigrationTabletParam() : magic_number_(MAGIC_NUM), - version_(PARAM_VERSION_V3), // TODO(@bowen.gbw): set version to v3 + version_(PARAM_VERSION_V3), // TODO(@gaishun.gs): set version to v3 is_empty_shell_(false), ls_id_(), tablet_id_(), diff --git a/tools/deploy/mysql_test/test_suite/msdt/t/hidden_table.test b/tools/deploy/mysql_test/test_suite/msdt/t/hidden_table.test index b0d06e500..3a8cb5f67 100644 --- a/tools/deploy/mysql_test/test_suite/msdt/t/hidden_table.test +++ b/tools/deploy/mysql_test/test_suite/msdt/t/hidden_table.test @@ -1,4 +1,4 @@ -#owner: bowen.gbw +#owner: jiahua.cjh #group: storage --disable_warnings diff --git a/tools/deploy/mysql_test/test_suite/msdt/t/lob.test b/tools/deploy/mysql_test/test_suite/msdt/t/lob.test index 25497e11e..5dd1dbabf 100644 --- a/tools/deploy/mysql_test/test_suite/msdt/t/lob.test +++ b/tools/deploy/mysql_test/test_suite/msdt/t/lob.test @@ -1,4 +1,4 @@ -#owner: bowen.gbw +#owner: jiahua.cjh #group: storage --disable_warnings