hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix the log message, make it consistent (#44)

Browse Source 
* Making the root service log consistent

* update log message

* fix typo

* making the log message consistent

Co-authored-by: EthanDBer <13810907+EthanDBer@users.noreply.github.com>
This commit is contained in:
Ethanzjp
2021-06-15 14:43:49 +08:00
committed by GitHub
parent 90bf58aa7c
commit 6aa3e351ce
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/clog/ob_batch_packet.cpp
View File

@ -35,7 +35,7 @@ int ObBatchPacketCodec::encode_batch_header(char* buf, const int64_t len, int64_
int64_t new_pos = pos;
if (OB_ISNULL(buf) || len <= 0 || pos < 0 || OB_INVALID_TIMESTAMP == timestamp || !server.is_valid() || count < 0) {
ret = OB_INVALID_ARGUMENT;
CLOG_LOG(WARN, "incalid argument", KP(buf), K(len), K(pos), K(timestamp), K(server), K(count));
CLOG_LOG(WARN, "invalid argument", KP(buf), K(len), K(pos), K(timestamp), K(server), K(count));
} else if (OB_FAIL(serialization::encode_i64(buf, len, new_pos, timestamp))) {
} else if (OB_FAIL(serialization::encode_i32(buf, len, new_pos, count))) {
} else if (OB_FAIL(server.serialize(buf, len, new_pos))) {

2
src/clog/ob_clog_file_writer.cpp
View File

@ -56,7 +56,7 @@ int ObCLogBaseFileWriter::init(
CLOG_LOG(WARN, "already inited", K(ret));
} else if (OB_ISNULL(log_dir) || OB_ISNULL(shm_path) || OB_ISNULL(file_store)) {
ret = OB_INVALID_ARGUMENT;
CLOG_LOG(WARN, "invalid param", K(ret), K(log_dir), K(align_size), KP(file_store));
CLOG_LOG(WARN, "invalid argument", K(ret), K(log_dir), K(align_size), KP(file_store));
} else if (OB_FAIL(ObBaseLogBufferMgr::get_instance().get_buffer(shm_path, log_ctrl_))) {
CLOG_LOG(WARN, "get log buf failed", K(ret), K(log_dir));
} else {

8
src/observer/ob_root_service_monitor.cpp
View File

@ -126,7 +126,7 @@ int ObRootServiceMonitor::monitor_root_service()
} else if (root_service_.is_stopping()) {
// need exit
if (OB_FAIL(root_service_.stop_service())) {
LOG_WARN("root_service stop_service failed", K(ret));
LOG_WARN("root service stop service failed", K(ret));
} else {
LOG_INFO("root service stop service finish success");
}
@ -143,7 +143,7 @@ int ObRootServiceMonitor::monitor_root_service()
LOG_INFO("try to start root service");
DEBUG_SYNC(BEFORE_START_RS);
if (OB_FAIL(try_start_root_service())) {
LOG_WARN("fail to start root_service", K(ret));
LOG_WARN("fail to start root service", K(ret));
} else {
LOG_INFO("start root service success");
}
@ -161,7 +161,7 @@ int ObRootServiceMonitor::monitor_root_service()
// nothing todo
} else if (root_service_.is_stopping()) {
if (OB_FAIL(root_service_.stop_service())) {
LOG_WARN("root_service stop_service failed", K(ret));
LOG_WARN("root service stop service failed", K(ret));
} else {
LOG_INFO("root service stop service finish success");
}
@ -223,7 +223,7 @@ int ObRootServiceMonitor::try_start_root_service()
if (OB_SUCC(ret)) {
LOG_INFO("try to start root service");
if (OB_FAIL(root_service_.start_service())) {
LOG_WARN("root_service start_service failed", K(ret));
LOG_WARN("root service start service failed", K(ret));
} else {
LOG_INFO("root service start service success", K(ret));
}