hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fixbug: drop database error, the database name address of stmt is illegal.

Browse Source
This commit is contained in:
791065426@qq.com
2023-11-20 17:11:02 +00:00
committed by ob-robot
parent 581e376ca0
commit 6bb6c68dae
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/resolver/ddl/ob_drop_database_resolver.cpp
View File

@ -43,7 +43,8 @@ int ObDropDatabaseResolver::resolve(const ParseNode &parse_tree)
if (OB_ISNULL(node) if (OB_ISNULL(node)
|| OB_UNLIKELY(node->type_ != T_DROP_DATABASE) || OB_UNLIKELY(node->type_ != T_DROP_DATABASE)
|| OB_UNLIKELY(node->num_child_ != DB_NODE_COUNT) || OB_UNLIKELY(node->num_child_ != DB_NODE_COUNT)
|| OB_ISNULL(node->children_)) { || OB_ISNULL(node->children_)
|| OB_ISNULL(allocator_)) {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
LOG_WARN("invalid parse tree", K(ret), K(node)); LOG_WARN("invalid parse tree", K(ret), K(node));
} else if (OB_ISNULL(session_info_)) { } else if (OB_ISNULL(session_info_)) {
@ -92,12 +93,16 @@ int ObDropDatabaseResolver::resolve(const ParseNode &parse_tree)
cs_type, perserve_lettercase, database_name))) { cs_type, perserve_lettercase, database_name))) {
LOG_WARN("fail to check and convert database name", K(database_name), K(ret)); LOG_WARN("fail to check and convert database name", K(database_name), K(ret));
} else { } else {
ObString deep_copy_database_name;
CK (OB_NOT_NULL(schema_checker_)); CK (OB_NOT_NULL(schema_checker_));
CK (OB_NOT_NULL(schema_checker_->get_schema_guard())); CK (OB_NOT_NULL(schema_checker_->get_schema_guard()));
OZ (ObSQLUtils::cvt_db_name_to_org(*schema_checker_->get_schema_guard(), OZ (ObSQLUtils::cvt_db_name_to_org(*schema_checker_->get_schema_guard(),
session_info_, session_info_,
database_name)); database_name));
OX (drop_database_stmt->set_database_name(database_name)); OZ (deep_copy_ob_string(*allocator_,
database_name,
deep_copy_database_name), database_name);
OX (drop_database_stmt->set_database_name(deep_copy_database_name));
} }
} }
} }