fix typo
This commit is contained in:
		| @ -110,7 +110,7 @@ private: | |||||||
|   int add_implicit_cast_for_op_row(ObRawExpr *&child_ptr, |   int add_implicit_cast_for_op_row(ObRawExpr *&child_ptr, | ||||||
|                                    const common::ObIArray<ObExprResType> &input_types, |                                    const common::ObIArray<ObExprResType> &input_types, | ||||||
|                                    const ObCastMode &cast_mode); |                                    const ObCastMode &cast_mode); | ||||||
|   // try add cast expr on subquery stmt's oubput && update column types. |   // try add cast expr on subquery stmt's output && update column types. | ||||||
|   int add_implicit_cast_for_subquery(ObQueryRefRawExpr &expr, |   int add_implicit_cast_for_subquery(ObQueryRefRawExpr &expr, | ||||||
|                                      const common::ObIArray<ObExprResType> &input_types, |                                      const common::ObIArray<ObExprResType> &input_types, | ||||||
|                                      const ObCastMode &cast_mode); |                                      const ObCastMode &cast_mode); | ||||||
|  | |||||||
| @ -37,7 +37,7 @@ public: | |||||||
|  |  | ||||||
|   int modifyColumnName(ObRawExpr &expr); |   int modifyColumnName(ObRawExpr &expr); | ||||||
|  |  | ||||||
|   // interface of ObRawExprVistor |   // interface of ObRawExprVisitor | ||||||
|   virtual int visit(ObConstRawExpr &expr); |   virtual int visit(ObConstRawExpr &expr); | ||||||
|   virtual int visit(ObExecParamRawExpr &expr); |   virtual int visit(ObExecParamRawExpr &expr); | ||||||
|   virtual int visit(ObVarRawExpr &expr); |   virtual int visit(ObVarRawExpr &expr); | ||||||
|  | |||||||
| @ -51,7 +51,7 @@ int ObRawExprReplacer::replace(ObRawExpr *&expr) | |||||||
|     expr = new_expr; |     expr = new_expr; | ||||||
|     replace_happened_ = true; |     replace_happened_ = true; | ||||||
|   } else if (OB_FAIL(expr->preorder_accept(*this))) { |   } else if (OB_FAIL(expr->preorder_accept(*this))) { | ||||||
|     LOG_WARN("failed to preorder accecpt expr", K(ret)); |     LOG_WARN("failed to preorder accept expr", K(ret)); | ||||||
|   } |   } | ||||||
|   return ret; |   return ret; | ||||||
| } | } | ||||||
|  | |||||||
| @ -26,8 +26,8 @@ namespace sql | |||||||
|  *    it is replaced when visit ObQueryRefRawExpr; |  *    it is replaced when visit ObQueryRefRawExpr; | ||||||
|  * 3. the replaced expr and its children will be skipped when traverse the expr tree, for example |  * 3. the replaced expr and its children will be skipped when traverse the expr tree, for example | ||||||
|  *    with replace rule [{c1 -> c1+c2+1}, {c2 -> c1+c2+2}] |  *    with replace rule [{c1 -> c1+c2+1}, {c2 -> c1+c2+2}] | ||||||
|  *    select c1, c2 from t1 will be transfromed into select c1+c2+1, c1+c2+2 from t1 |  *    select c1, c2 from t1 will be transformed into select c1+c2+1, c1+c2+2 from t1 | ||||||
|  *    In constrast, ObTransformUtils::replace_expr will return OB_SIZE_OVERFLOW unexpectedly; |  *    In contrast, ObTransformUtils::replace_expr will return OB_SIZE_OVERFLOW unexpectedly; | ||||||
|  */ |  */ | ||||||
| class ObRawExprReplacer: public ObRawExprVisitor | class ObRawExprReplacer: public ObRawExprVisitor | ||||||
| { | { | ||||||
| @ -87,7 +87,7 @@ private: | |||||||
|   hash::ObHashMap<uint64_t, uint64_t> expr_replace_map_; |   hash::ObHashMap<uint64_t, uint64_t> expr_replace_map_; | ||||||
|  |  | ||||||
|   bool replace_happened_; |   bool replace_happened_; | ||||||
|    //If true, skip param epxrs which are resolved as flags instead of exprs in mysql. |    //If true, skip param exprs which are resolved as flags instead of exprs in mysql. | ||||||
|    //(e.g. the second param of IS expr) |    //(e.g. the second param of IS expr) | ||||||
|   bool skip_bool_param_mysql_; |   bool skip_bool_param_mysql_; | ||||||
| }; | }; | ||||||
|  | |||||||
		Reference in New Issue
	
	Block a user
	 chenhuiming
					chenhuiming