This commit is contained in:
chenhuiming
2023-01-11 10:01:00 +08:00
parent 9dc9c4894f
commit 6c6f4fc224
4 changed files with 6 additions and 6 deletions

View File

@ -110,7 +110,7 @@ private:
int add_implicit_cast_for_op_row(ObRawExpr *&child_ptr,
const common::ObIArray<ObExprResType> &input_types,
const ObCastMode &cast_mode);
// try add cast expr on subquery stmt's oubput && update column types.
// try add cast expr on subquery stmt's output && update column types.
int add_implicit_cast_for_subquery(ObQueryRefRawExpr &expr,
const common::ObIArray<ObExprResType> &input_types,
const ObCastMode &cast_mode);

View File

@ -37,7 +37,7 @@ public:
int modifyColumnName(ObRawExpr &expr);
// interface of ObRawExprVistor
// interface of ObRawExprVisitor
virtual int visit(ObConstRawExpr &expr);
virtual int visit(ObExecParamRawExpr &expr);
virtual int visit(ObVarRawExpr &expr);

View File

@ -51,7 +51,7 @@ int ObRawExprReplacer::replace(ObRawExpr *&expr)
expr = new_expr;
replace_happened_ = true;
} else if (OB_FAIL(expr->preorder_accept(*this))) {
LOG_WARN("failed to preorder accecpt expr", K(ret));
LOG_WARN("failed to preorder accept expr", K(ret));
}
return ret;
}

View File

@ -26,8 +26,8 @@ namespace sql
* it is replaced when visit ObQueryRefRawExpr;
* 3. the replaced expr and its children will be skipped when traverse the expr tree, for example
* with replace rule [{c1 -> c1+c2+1}, {c2 -> c1+c2+2}]
* select c1, c2 from t1 will be transfromed into select c1+c2+1, c1+c2+2 from t1
* In constrast, ObTransformUtils::replace_expr will return OB_SIZE_OVERFLOW unexpectedly;
* select c1, c2 from t1 will be transformed into select c1+c2+1, c1+c2+2 from t1
* In contrast, ObTransformUtils::replace_expr will return OB_SIZE_OVERFLOW unexpectedly;
*/
class ObRawExprReplacer: public ObRawExprVisitor
{
@ -87,7 +87,7 @@ private:
hash::ObHashMap<uint64_t, uint64_t> expr_replace_map_;
bool replace_happened_;
//If true, skip param epxrs which are resolved as flags instead of exprs in mysql.
//If true, skip param exprs which are resolved as flags instead of exprs in mysql.
//(e.g. the second param of IS expr)
bool skip_bool_param_mysql_;
};